This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/

On June 5th, 2014, 10:58 a.m. UTC, David Faure wrote:

Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs?

On June 5th, 2014, 11:05 a.m. UTC, Hrvoje Senjan wrote:

i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely...

On June 5th, 2014, 11:21 a.m. UTC, David Faure wrote:

Unless I'm wrong, video/* didn't work in kdelibs4 either.

(IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec).

On June 5th, 2014, 3:11 p.m. UTC, Hrvoje Senjan wrote:

maybe it *shouldn't* work with 4.x - but i do have thumbs in 4.x dolphin with such a desktop file ;-)
but then http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html has it still wrong (that's why i havent removed video/* completely):
"Note that you can supply a comma-separated list of mimetypes to the MimeTypes entry, naming all mimetypes your ThumbCreator supports. You can also use simple wildcards, like "text/*"."

On June 5th, 2014, 3:18 p.m. UTC, David Faure wrote:

ah it's a ThumbCreator, not an app, I see.

kio/src/widgets/previewjob.cpp still supports video/*, see the variable "groupMimeType" in there. So it should work. You can debug it there if it doesn't :-)
AFAIK there aren't any video codecs or muxes that ffmpeg doesn't support (especially not any with a known mimetype), so IMHO video/* should stay.

- Martin Tobias Holmedahl


On June 5th, 2014, 10:47 a.m. UTC, Hrvoje Senjan wrote:

Review request for KDE Multimedia and David Faure.
By Hrvoje Senjan.

Updated June 5, 2014, 10:47 a.m.

Repository: ffmpegthumbs

Description

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing

Builds; thumbnails appear in Dolphin.

Diffs

  • ffmpegthumbs.desktop (1e2a95a)
  • ffmpegthumbnailer/imagewriter.cpp (7dae371)
  • ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
  • ffmpegthumbnailer.cpp (03a40c3)
  • CMakeLists.txt (dd0974f)

View Diff