[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-multimedia
Subject: Re: Review Request 118545: ffmpegthumbs: Port to Frameworks
From: "David Faure" <faure () kde ! org>
Date: 2014-06-05 15:18:09
Message-ID: 20140605151809.32751.38799 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 5, 2014, 10:58 a.m., David Faure wrote:
> > Correct, video/* isn't supported. In any case, how can you be sure that this \
> > application will support *ALL* video codecs?
>
> Hrvoje Senjan wrote:
> i cannot - this was used in 4.x version, i've added a few specific ones validated \
> they work. will adjust the review, and remove the /* completely...
> David Faure wrote:
> Unless I'm wrong, video/* didn't work in kdelibs4 either.
>
> (IIRC it worked for ServiceMenus, but not for application desktop files, which have \
> to follow the Desktop Entry Spec).
> Hrvoje Senjan wrote:
> maybe it *shouldn't* work with 4.x - but i do have thumbs in 4.x dolphin with such \
> a desktop file ;-) but then \
> http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html \
> has it still wrong (that's why i havent removed video/* completely): "Note that you \
> can supply a comma-separated list of mimetypes to the MimeTypes entry, naming all \
> mimetypes your ThumbCreator supports. You can also use simple wildcards, like \
> "text/*"."
ah it's a ThumbCreator, not an app, I see.
kio/src/widgets/previewjob.cpp still supports video/*, see the variable \
"groupMimeType" in there. So it should work. You can debug it there if it doesn't :-)
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118545/#review59312
-----------------------------------------------------------
On June 5, 2014, 10:47 a.m., Hrvoje Senjan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118545/
> -----------------------------------------------------------
>
> (Updated June 5, 2014, 10:47 a.m.)
>
>
> Review request for KDE Multimedia and David Faure.
>
>
> Repository: ffmpegthumbs
>
>
> Description
> -------
>
> simple port to KF5.
> added Alex if he maybe has an idea why video/* doesn't seem to work.
>
>
> Diffs
> -----
>
> ffmpegthumbs.desktop 1e2a95a
> ffmpegthumbnailer/imagewriter.cpp 7dae371
> ffmpegthumbnailer/moviedecoder.cpp d63cd4b
> ffmpegthumbnailer.cpp 03a40c3
> CMakeLists.txt dd0974f
>
> Diff: https://git.reviewboard.kde.org/r/118545/diff/
>
>
> Testing
> -------
>
> Builds; thumbnails appear in Dolphin.
>
>
> Thanks,
>
> Hrvoje Senjan
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118545/">https://git.reviewboard.kde.org/r/118545/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 5th, 2014, 10:58 a.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Correct, video/* isn't supported. In any case, how can you be sure \
that this application will support *ALL* video codecs?</pre> </blockquote>
<p>On June 5th, 2014, 11:05 a.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">i cannot - this was used \
in 4.x version, i've added a few specific ones validated they work. will adjust \
the review, and remove the /* completely...</pre> </blockquote>
<p>On June 5th, 2014, 11:21 a.m. UTC, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unless I'm wrong, \
video/* didn't work in kdelibs4 either.
(IIRC it worked for ServiceMenus, but not for application desktop files, which have \
to follow the Desktop Entry Spec).</pre> </blockquote>
<p>On June 5th, 2014, 3:11 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">maybe it *shouldn't* \
work with 4.x - but i do have thumbs in 4.x dolphin with such a desktop file ;-) but \
then http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html \
has it still wrong (that's why i havent removed video/* completely): "Note \
that you can supply a comma-separated list of mimetypes to the MimeTypes entry, \
naming all mimetypes your ThumbCreator supports. You can also use simple wildcards, \
like "text/*"."</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah it's a \
ThumbCreator, not an app, I see.
kio/src/widgets/previewjob.cpp still supports video/*, see the variable \
"groupMimeType" in there. So it should work. You can debug it there if it \
doesn't :-)</pre> <br />
<p>- David</p>
<br />
<p>On June 5th, 2014, 10:47 a.m. UTC, Hrvoje Senjan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Multimedia and David Faure.</div>
<div>By Hrvoje Senjan.</div>
<p style="color: grey;"><i>Updated June 5, 2014, 10:47 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ffmpegthumbs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">simple port to KF5. added Alex if he maybe has an idea why video/* \
doesn't seem to work.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds; thumbnails appear in Dolphin.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ffmpegthumbs.desktop <span style="color: grey">(1e2a95a)</span></li>
<li>ffmpegthumbnailer/imagewriter.cpp <span style="color: \
grey">(7dae371)</span></li>
<li>ffmpegthumbnailer/moviedecoder.cpp <span style="color: \
grey">(d63cd4b)</span></li>
<li>ffmpegthumbnailer.cpp <span style="color: grey">(03a40c3)</span></li>
<li>CMakeLists.txt <span style="color: grey">(dd0974f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118545/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic