From kde-multimedia Thu Jun 05 15:11:45 2014 From: "Hrvoje Senjan" Date: Thu, 05 Jun 2014 15:11:45 +0000 To: kde-multimedia Subject: Re: Review Request 118545: ffmpegthumbs: Port to Frameworks Message-Id: <20140605151145.17323.8392 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=140198112515569 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5421606668452227913==" --===============5421606668452227913== Content-Type: multipart/alternative; boundary="===============3724299565461719329==" --===============3724299565461719329== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On June 5, 2014, 12:58 p.m., David Faure wrote: > > Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs? > > Hrvoje Senjan wrote: > i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely... > > David Faure wrote: > Unless I'm wrong, video/* didn't work in kdelibs4 either. > > (IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec). maybe it *shouldn't* work with 4.x - but i do have thumbs in 4.x dolphin with such a desktop file ;-) but then http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html has it still wrong (that's why i havent removed video/* completely): "Note that you can supply a comma-separated list of mimetypes to the MimeTypes entry, naming all mimetypes your ThumbCreator supports. You can also use simple wildcards, like "text/*"." - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/#review59312 ----------------------------------------------------------- On June 5, 2014, 12:47 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118545/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 12:47 p.m.) > > > Review request for KDE Multimedia and David Faure. > > > Repository: ffmpegthumbs > > > Description > ------- > > simple port to KF5. > added Alex if he maybe has an idea why video/* doesn't seem to work. > > > Diffs > ----- > > ffmpegthumbs.desktop 1e2a95a > ffmpegthumbnailer/imagewriter.cpp 7dae371 > ffmpegthumbnailer/moviedecoder.cpp d63cd4b > ffmpegthumbnailer.cpp 03a40c3 > CMakeLists.txt dd0974f > > Diff: https://git.reviewboard.kde.org/r/118545/diff/ > > > Testing > ------- > > Builds; thumbnails appear in Dolphin. > > > Thanks, > > Hrvoje Senjan > > --===============3724299565461719329== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/

On June 5th, 2014, 12:58 p.m. CEST, David Faure wrote:

Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs?

On June 5th, 2014, 1:05 p.m. CEST, Hrvoje Senjan wrote:

i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely...

On June 5th, 2014, 1:21 p.m. CEST, David Faure wrote:

Unless I'm wrong, video/* didn't work in kdelibs4 either.

(IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec).

maybe it *shouldn't* work with 4.x - but i do have thumbs in 4.x dolphin with such a desktop file ;-)
but then http://api.kde.org/frameworks-api/frameworks5-apidocs/kio/html/classThumbCreator.html has it still wrong (that's why i havent removed video/* completely):
"Note that you can supply a comma-separated list of mimetypes to the MimeTypes entry, naming all mimetypes your ThumbCreator supports. You can also use simple wildcards, like "text/*"."

- Hrvoje

On June 5th, 2014, 12:47 p.m. CEST, Hrvoje Senjan wrote:

Review request for KDE Multimedia and David Faure.

By Hrvoje Senjan.

Updated June 5, 2014, 12:47 p.m.

Repository: ffmpegthumbs

Description

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing

Builds; thumbnails appear in Dolphin.

Diffs

ffmpegthumbs.desktop (1e2a95a)
ffmpegthumbnailer/imagewriter.cpp (7dae371)
ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
ffmpegthumbnailer.cpp (03a40c3)
CMakeLists.txt (dd0974f)

--===============3724299565461719329==-- --===============5421606668452227913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============5421606668452227913==--