From kde-multimedia Thu Jun 05 11:21:20 2014 From: "David Faure" Date: Thu, 05 Jun 2014 11:21:20 +0000 To: kde-multimedia Subject: Re: Review Request 118545: ffmpegthumbs: Port to Frameworks Message-Id: <20140605112120.17323.55848 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=140196729619515 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6808289020713136276==" --===============6808289020713136276== Content-Type: multipart/alternative; boundary="===============8872648965028826542==" --===============8872648965028826542== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On June 5, 2014, 10:58 a.m., David Faure wrote: > > Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs? > > Hrvoje Senjan wrote: > i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely... Unless I'm wrong, video/* didn't work in kdelibs4 either. (IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec). - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/#review59312 ----------------------------------------------------------- On June 5, 2014, 10:47 a.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118545/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 10:47 a.m.) > > > Review request for KDE Multimedia and David Faure. > > > Repository: ffmpegthumbs > > > Description > ------- > > simple port to KF5. > added Alex if he maybe has an idea why video/* doesn't seem to work. > > > Diffs > ----- > > ffmpegthumbs.desktop 1e2a95a > ffmpegthumbnailer/imagewriter.cpp 7dae371 > ffmpegthumbnailer/moviedecoder.cpp d63cd4b > ffmpegthumbnailer.cpp 03a40c3 > CMakeLists.txt dd0974f > > Diff: https://git.reviewboard.kde.org/r/118545/diff/ > > > Testing > ------- > > Builds; thumbnails appear in Dolphin. > > > Thanks, > > Hrvoje Senjan > > --===============8872648965028826542== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/

On June 5th, 2014, 10:58 a.m. UTC, David Faure wrote:

Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs?

On June 5th, 2014, 11:05 a.m. UTC, Hrvoje Senjan wrote:

i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely...
Unless I'm wrong, video/* didn't work in kdelibs4 either.

(IIRC it worked for ServiceMenus, but not for application desktop files, which have to follow the Desktop Entry Spec).

- David


On June 5th, 2014, 10:47 a.m. UTC, Hrvoje Senjan wrote:

Review request for KDE Multimedia and David Faure.
By Hrvoje Senjan.

Updated June 5, 2014, 10:47 a.m.

Repository: ffmpegthumbs

Description 

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing 

Builds; thumbnails appear in Dolphin.

Diffs

  • ffmpegthumbs.desktop (1e2a95a)
  • ffmpegthumbnailer/imagewriter.cpp (7dae371)
  • ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
  • ffmpegthumbnailer.cpp (03a40c3)
  • CMakeLists.txt (dd0974f)

View Diff
--===============8872648965028826542==-- --===============6808289020713136276== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============6808289020713136276==--