--===============9188377711615361103== Content-Type: multipart/alternative; boundary="===============1311965100015017614==" --===============1311965100015017614== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On June 5, 2014, 12:58 p.m., David Faure wrote: > > Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs? i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely... - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/#review59312 ----------------------------------------------------------- On June 5, 2014, 12:47 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118545/ > ----------------------------------------------------------- > > (Updated June 5, 2014, 12:47 p.m.) > > > Review request for KDE Multimedia and David Faure. > > > Repository: ffmpegthumbs > > > Description > ------- > > simple port to KF5. > added Alex if he maybe has an idea why video/* doesn't seem to work. > > > Diffs > ----- > > ffmpegthumbs.desktop 1e2a95a > ffmpegthumbnailer/imagewriter.cpp 7dae371 > ffmpegthumbnailer/moviedecoder.cpp d63cd4b > ffmpegthumbnailer.cpp 03a40c3 > CMakeLists.txt dd0974f > > Diff: https://git.reviewboard.kde.org/r/118545/diff/ > > > Testing > ------- > > Builds; thumbnails appear in Dolphin. > > > Thanks, > > Hrvoje Senjan > > --===============1311965100015017614== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118545/

On June 5th, 2014, 12:58 p.m. CEST, David Faure wrote:
Correct, video/* isn't supported. In any case, how can you be sure that this application will support *ALL* video codecs?

i cannot - this was used in 4.x version, i've added a few specific ones validated they work. will adjust the review, and remove the /* completely...

- Hrvoje

On June 5th, 2014, 12:47 p.m. CEST, Hrvoje Senjan wrote:

Review request for KDE Multimedia and David Faure.

By Hrvoje Senjan.

Updated June 5, 2014, 12:47 p.m.

Repository: ffmpegthumbs

Description

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.

Testing

Builds; thumbnails appear in Dolphin.

Diffs

ffmpegthumbs.desktop (1e2a95a)
ffmpegthumbnailer/imagewriter.cpp (7dae371)
ffmpegthumbnailer/moviedecoder.cpp (d63cd4b)
ffmpegthumbnailer.cpp (03a40c3)
CMakeLists.txt (dd0974f)

View Diff

--===============1311965100015017614==-- --===============9188377711615361103== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============9188377711615361103==--