'Review Request 118545: ffmpegthumbs: Port to Frameworks'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Review Request 118545: ffmpegthumbs: Port to Frameworks
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2014-06-04 21:56:05
Message-ID: 20140604215605.17323.94339 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118545/
-----------------------------------------------------------

Review request for KDE Multimedia and Alex Merry.

Repository: ffmpegthumbs

Description
-------

simple port to KF5.
added Alex if he maybe has an idea why video/* doesn't seem to work.

Diffs
-----

  ffmpegthumbs.desktop 1e2a95a 
  ffmpegthumbnailer/imagewriter.cpp 7dae371 
  ffmpegthumbnailer/moviedecoder.cpp d63cd4b 
  ffmpegthumbnailer.cpp 03a40c3 
  CMakeLists.txt dd0974f 

Diff: https://git.reviewboard.kde.org/r/118545/diff/

Testing
-------

Builds; thumbnails appear in Dolphin.

Thanks,

Hrvoje Senjan

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/118545/">https://git.reviewboard.kde.org/r/118545/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Multimedia and Alex Merry.</div>
<div>By Hrvoje Senjan.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
ffmpegthumbs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">simple port to KF5. added Alex if he maybe has an idea why video/* \
doesn&#39;t seem to work.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Builds; thumbnails appear in Dolphin.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>ffmpegthumbs.desktop <span style="color: grey">(1e2a95a)</span></li>

 <li>ffmpegthumbnailer/imagewriter.cpp <span style="color: \
grey">(7dae371)</span></li>

 <li>ffmpegthumbnailer/moviedecoder.cpp <span style="color: \
grey">(d63cd4b)</span></li>

 <li>ffmpegthumbnailer.cpp <span style="color: grey">(03a40c3)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(dd0974f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/118545/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 