'Review Request 113223: replace Qt3 compatibility widgets by native Qt4 widgets'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Review Request 113223: replace Qt3 compatibility widgets by native Qt4 widgets
From:       Jiří Pinkava <j-pi () seznam ! cz>
Date:       2013-10-12 23:02:11
Message-ID: 20131012230211.9828.44258 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113223/
-----------------------------------------------------------

Review request for KDE Multimedia.

Repository: kamera

Description
-------

Remove Qt3Support dependecy.

Note that include directive for QVBoxLayout has beed removed because it compiles withought it. If annyone \
thing it should be kept, then include for QHBoxLayout should be added because it is now used.

Diffs
-----

  kcontrol/CMakeLists.txt 9e6603f 
  kcontrol/kameraconfigdialog.cpp b0d601f 

Diff: http://git.reviewboard.kde.org/r/113223/diff/

Testing
-------

Build

I have no cammera -> not runtime test.

Thanks,

Jiří Pinkava

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/113223/">http://git.reviewboard.kde.org/r/113223/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Multimedia.</div>
<div>By Jiří Pinkava.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kamera
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove Qt3Support dependecy.

Note that include directive for QVBoxLayout has beed removed because it compiles withought it. If annyone \
thing it should be kept, then include for QHBoxLayout should be added because it is now used.</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build

I have no cammera -&gt; not runtime test.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kcontrol/CMakeLists.txt <span style="color: grey">(9e6603f)</span></li>

 <li>kcontrol/kameraconfigdialog.cpp <span style="color: grey">(b0d601f)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/113223/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 