From kde-multimedia Tue Sep 17 06:19:59 2013 From: "James Smith" Date: Tue, 17 Sep 2013 06:19:59 +0000 To: kde-multimedia Subject: Re: Review Request 112076: Fix bug where monitor won't powersave even with only audio content Message-Id: <20130917061959.8529.80801 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-multimedia&m=137939882427602 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2650908621854365700==" --===============2650908621854365700== Content-Type: multipart/alternative; boundary="===============4258503126172050327==" --===============4258503126172050327== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112076/ ----------------------------------------------------------- (Updated Sept. 17, 2013, 6:19 a.m.) Review request for KDE Multimedia and Harald Sitter. Changes ------- Bracket spacing and restore a clipped comment. Description ------- Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off. Diffs (updated) ----- src/app/videoWindow.cpp a325a6e src/app/videoWindow.h ab61ed0 src/app/stateChange.cpp 0edde72 src/app/mainWindow.cpp f850820 src/app/mainWindow.h 51ef72c src/app/audioView2.cpp f2ddc44 src/app/audioView2.h 6c04b47 Diff: http://git.reviewboard.kde.org/r/112076/diff/ Testing ------- Compile, run-test Thanks, James Smith --===============4258503126172050327== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112076/

Review request for KDE Multimedia and Harald Sitter.
By James Smith.

Updated Sept. 17, 2013, 6:19 a.m.

Changes

Bracket spacing and restore a clipped comment.

Description

Fixes an issue where playing audio content keeps the screen awake. Video content is supposed to, but with the new play URL button, dragon should allow the monitor to turn off.

Testing

Compile, run-test

Diffs (updated)

  • src/app/videoWindow.cpp (a325a6e)
  • src/app/videoWindow.h (ab61ed0)
  • src/app/stateChange.cpp (0edde72)
  • src/app/mainWindow.cpp (f850820)
  • src/app/mainWindow.h (51ef72c)
  • src/app/audioView2.cpp (f2ddc44)
  • src/app/audioView2.h (6c04b47)

View Diff

--===============4258503126172050327==-- --===============2650908621854365700== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia --===============2650908621854365700==--