'Re: Review Request 110273: Juk should be able to exclude folders.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Review Request 110273: Juk should be able to exclude folders.
From:       "Commit Hook" <null () kde ! org>
Date:       2013-05-26 2:10:38
Message-ID: 20130526021038.27595.2807 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110273/
-----------------------------------------------------------

(Updated May 26, 2013, 2:10 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Multimedia.

Description
-------

If we add some folders to Juk's watching list, Juk will add everything
in the folder. But sometimes, we don't want Juk to add some folders.
There isn't a way to exclude folders.

It is bugging me all the time. I can't stand it so I starting patching
it with a little C++ and Qt knowledge.

Here is my patch. If my patch can merge into mainline, our users
should be happier :). I don't have much C++ experience, there are some
hacks in my code, but that's the best what I can do. So please help me
to improve it.

This addresses bug 319106.
    http://bugs.kde.org/show_bug.cgi?id=319106

Diffs
-----

  collectionlist.h e8c15de 
  collectionlist.cpp f4df66b 
  directorylist.h f13756f 
  directorylist.cpp b715a2c 
  directorylistbase.ui 6146726 
  playlist.h 1fc640b 
  playlist.cpp 2153f9b 
  playlistcollection.h d9fd9ff 
  playlistcollection.cpp fbb33a6 

Diff: http://git.reviewboard.kde.org/r/110273/diff/

Testing
-------

Yes, it works for me.
But I need some help to improve the patch. Nobody reviews the new version? 

Thanks,

Tom Li

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/110273/">http://git.reviewboard.kde.org/r/110273/</a>
     </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Multimedia.</div>
<div>By Tom Li.</div>

<p style="color: grey;"><i>Updated May 26, 2013, 2:10 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we add some folders to Juk&#39;s watching \
list, Juk will add everything in the folder. But sometimes, we don&#39;t want Juk to add some folders.
There isn&#39;t a way to exclude folders.

It is bugging me all the time. I can&#39;t stand it so I starting patching
it with a little C++ and Qt knowledge.

Here is my patch. If my patch can merge into mainline, our users
should be happier :). I don&#39;t have much C++ experience, there are some
hacks in my code, but that&#39;s the best what I can do. So please help me
to improve it.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, it works for me. But I need some help \
to improve the patch. Nobody reviews the new version? </pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=319106">319106</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>collectionlist.h <span style="color: grey">(e8c15de)</span></li>

 <li>collectionlist.cpp <span style="color: grey">(f4df66b)</span></li>

 <li>directorylist.h <span style="color: grey">(f13756f)</span></li>

 <li>directorylist.cpp <span style="color: grey">(b715a2c)</span></li>

 <li>directorylistbase.ui <span style="color: grey">(6146726)</span></li>

 <li>playlist.h <span style="color: grey">(1fc640b)</span></li>

 <li>playlist.cpp <span style="color: grey">(2153f9b)</span></li>

 <li>playlistcollection.h <span style="color: grey">(d9fd9ff)</span></li>

 <li>playlistcollection.cpp <span style="color: grey">(fbb33a6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/110273/diff/" style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 