From kde-multimedia Thu Sep 27 03:38:22 2012 From: Michael Pyne Date: Thu, 27 Sep 2012 03:38:22 +0000 To: kde-multimedia Subject: [Bug 307343] audiocd-kio 4.9.1 does not supply vorbis support Message-Id: X-MARC-Message: https://marc.info/?l=kde-multimedia&m=134871711724772 https://bugs.kde.org/show_bug.cgi?id=307343 Michael Pyne changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mpyne@kde.org --- Comment #4 from Michael Pyne --- Felix: I like the idea of your second patch to remove HAVE_VORBIS entirely. It would require the CMake check to be modified so that we don't try to compile if the correct version of the library isn't present (my version of CMake appears to already export data about which version of libvorbis was found, so this should hopefully be easy). In any event there's no emergency here so we can hold off until 4.10 before we change the required version of libvorbis. If you could please send the code change patch along to the kde-multimedia mailing list for discussion/development I would appreciate it, Bugzilla isn't really the best place for code review. ;-) -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ kde-multimedia mailing list kde-multimedia@kde.org https://mail.kde.org/mailman/listinfo/kde-multimedia