'Review Request: Allow opening context menu from keyboard in volume slider'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Review Request: Allow opening context menu from keyboard in volume slider
From:       José Millán Soto <fid () gpul ! org>
Date:       2012-09-26 19:50:52
Message-ID: 20120926195052.23080.37074 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106585/
-----------------------------------------------------------

Review request for KDE Accessibility and KDE Multimedia.

Description
-------

The context menu of the volume sliders in KMix can only be opened when righ=
t-clicking a slider. This is an accessibility problem as users who cannot u=
se a mouse cannot open the menu.
This patch allows to open the context menu using the context menu key.

Diffs
-----

  gui/mdwslider.cpp 4454510 =

Diff: http://git.reviewboard.kde.org/r/106585/diff/

Testing
-------

Thanks,

Jos=C3=A9 Mill=C3=A1n Soto

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/106585/">http://git.reviewboard.kde.org/r/106585/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Accessibility and KDE Multimedia.</div>
<div>By José Millán Soto.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The context menu of the volume sliders in KMix can only be opened when \
right-clicking a slider. This is an accessibility problem as users who cannot use a \
mouse cannot open the menu. This patch allows to open the context menu using the \
context menu key.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>gui/mdwslider.cpp <span style="color: grey">(4454510)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/106585/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 