'Re: Review Request: fix audioChannel indexing'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Review Request: fix audioChannel indexing
From:       "Harald Sitter" <sitter () kde ! org>
Date:       2011-08-23 10:38:12
Message-ID: 20110823103812.11759.20451 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102298/#review5939
-----------------------------------------------------------

We really do not understand what this change is supposed to do nor what it =
is supposed to fix.

It would be very helpful if you could add more details about what is going =
wrong, how this issue presents itself and why the patch you presented fixes=
 the issue.

(ideally you should do this in a bug report on bugs.kde.org I might add ;))

- Harald

On Aug. 23, 2011, 6:33 a.m., Sian Cao wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102298/
> -----------------------------------------------------------
> =

> (Updated Aug. 23, 2011, 6:33 a.m.)
> =

> =

> Review request for KDE Multimedia, Phonon Backends and Harald Sitter.
> =

> =

> Summary
> -------
> =

> libvlc seems have broken id rule, and liblc don't use p_info->i_id as ind=
ex of audio tracks.
> =

> =

> Diffs
> -----
> =

>   src/mediacontroller.cpp 3aa7b96 =

> =

> Diff: http://git.reviewboard.kde.org/r/102298/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Sian
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/102298/">http://git.reviewboard.kde.org/r/102298/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We really do not \
understand what this change is supposed to do nor what it is supposed to fix.

It would be very helpful if you could add more details about what is going wrong, how \
this issue presents itself and why the patch you presented fixes the issue.

(ideally you should do this in a bug report on bugs.kde.org I might add ;))</pre>
 <br />

<p>- Harald</p>

<br />
<p>On August 23rd, 2011, 6:33 a.m., Sian Cao wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Multimedia, Phonon Backends and Harald Sitter.</div>
<div>By Sian Cao.</div>

<p style="color: grey;"><i>Updated Aug. 23, 2011, 6:33 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">libvlc seems have broken id rule, and liblc don&#39;t use \
p_info-&gt;i_id as index of audio tracks. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/mediacontroller.cpp <span style="color: grey">(3aa7b96)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/102298/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread] 