[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    [PATCH] juk: save TagEditor's configuration on exit.
From:       Γι <ge
Date:       2011-04-29 8:48:34
Message-ID: BANLkTi=ASzk5h1Wypfv5Hv41Y5pAqe3-_w () mail ! gmail ! com
[Download RAW message or body]

Hi all,

I noticed that every time I restarted Juk, I had to re-select
View-->Show TagEditor for the latter to show up.

After investigation, I found out that the TagEditor's configuration
was not saved upon exit, becausePlaylistSplitter::m_editor was never
delete-d in PlaylistSplitter's dtor, so TagEditor::saveConfig() was
never called.

The attached patch fixes this.

Regards,

-- 
Γιώργος Κυλάφας (Giorgos Kylafas)
http://en.wikipedia.org/wiki/Posting_style#Inline_replying

["tageditor-save-config.patch" (text/x-diff)]

commit a5f37afadfefba320f8a9f840d5237dad17b89e0
Author: Γιώργος Κυλάφας (Giorgos Kylafas) <gekylafas@gmail.com>
Date:   Sat Apr 23 21:58:12 2011 +0300

    juk: save TagEditor's configuration on exit.
    
    PlaylistSplitter::m_editor was never delete-d in PlaylistSplitter's
    dtor, so TagEditor::saveConfig() was never called.

diff --git a/juk/playlistsplitter.cpp b/juk/playlistsplitter.cpp
index 3b13b68..8491b97 100644
--- a/juk/playlistsplitter.cpp
+++ b/juk/playlistsplitter.cpp
@@ -70,6 +70,8 @@ PlaylistSplitter::~PlaylistSplitter()
 {
     saveConfig();
 
+    delete m_editor;
+
     // NowPlaying depends on the PlaylistCollection, so kill it now.
     delete m_nowPlaying;
     m_nowPlaying = 0;


_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]