[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    [PATCH] juk: properly translate all tags in file renamer.
From:       Γι <ge
Date:       2011-04-20 15:02:24
Message-ID: BANLkTinXq8MBbXyJNGzvBQEAaraDg7NTOA () mail ! gmail ! com
[Download RAW message or body]

2011/4/20 Michael Pyne <mpyne@kde.org>:
> On Wednesday, April 20, 2011 00:49:46 Giorgos Kylafas wrote:
>> I could only insert categories "Track" and "Title" to the File Renamer
>> and not any of the others.
>>
>> At some point, I realized that those two were the only non-translated
>> categories appearing in the combobox, [...]

I also found out why those two were showing up untranslated even
though they had been properly translated in my language's juk.po. I
believe the attached patch fixes this.

> Thanks for looking into the issue!

Thank *you* for applying my fixes. I have been meaning to scratch my
juk-itches since ages, but only now have I found the time to do it.

> [...]
> I do think that bug 118317 was a separate issue, even affecting en_US users
> who hadn't been running JuK for years and so the problem you were having is
> different. However I will CC: that bug in case other commenters were having
> your issue.

Yes, it was a separate issue but it may have seemed to a casual
observer as the same, that's why I mentioned it. :-)

-- 
Γιώργος Κυλάφας (Giorgos Kylafas)
http://en.wikipedia.org/wiki/Posting_style#Inline_replying

["translate-all-tags.patch" (text/x-diff)]

commit 42e6600eb8a1d25365719feb4e13f41078672485
Author: Γιώργος Κυλάφας (Giorgos Kylafas) <gekylafas@gmail.com>
Date:   Wed Apr 20 13:28:49 2011 +0300

    juk: properly translate all tags in file renamer.
    
    Translatable strings for tags "Title" and "Track" are defined with a
    translation context, so make sure we use it when it is non-NULL.
---
 juk/tagrenameroptions.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/juk/tagrenameroptions.cpp b/juk/tagrenameroptions.cpp
index 7395284..326b4af 100644
--- a/juk/tagrenameroptions.cpp
+++ b/juk/tagrenameroptions.cpp
@@ -127,7 +127,7 @@ QString TagRenamerOptions::tagTypeText(TagType type, bool translate)
     }
 
     if(translate)
-        return context ? i18n(msg) : i18nc(context, msg);
+        return context ? i18nc(context, msg) : i18n(msg);
     else
         return msg;
 }


_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]