[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    [PATCH] juk: filerename: use translated stings when searching for
From:       Γι <ge
Date:       2011-04-19 21:49:46
Message-ID: BANLkTikLg8z-iw0wbraLrK6vhHRY1KL4yQ () mail ! gmail ! com
[Download RAW message or body]

Hi all,

I experienced the problem mentioned in
https://bugs.kde.org/show_bug.cgi?id=118317, however commit
http://websvn.kde.org/?view=revision&revision=988893 did not fix it
for me.
I could only insert categories "Track" and "Title" to the File Renamer
and not any of the others.

At some point, I realized that those two were the only non-translated
categories appearing in the combobox, so I after searching for a while
I managed to fix the problem with the attached patch. From what I can
understand from the code, tagTypeText() should be called with
"translate = false" only when read/writing the config file, and not
inside tagFromCategoryTest().

Regards,

-- 
Γιώργος Κυλάφας (Giorgos Kylafas)
http://en.wikipedia.org/wiki/Posting_style#Inline_replying

["insert-category.patch" (text/x-diff)]

commit 477e6007e53b20c53df37a3080e865315ac0a5f1
Author: Γιώργος Κυλάφας (Giorgos Kylafas) <gekylafas@gmail.com>
Date:   Wed Apr 20 00:28:12 2011 +0300

    juk: filerename: use translated stings when searching for category to insert.
---
 juk/tagrenameroptions.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/juk/tagrenameroptions.cpp b/juk/tagrenameroptions.cpp
index 9f8dcec..7395284 100644
--- a/juk/tagrenameroptions.cpp
+++ b/juk/tagrenameroptions.cpp
@@ -174,7 +174,7 @@ void TagRenamerOptions::saveConfig(unsigned categoryNum) const
 TagType TagRenamerOptions::tagFromCategoryText(const QString &text)
 {
     for(unsigned i = StartTag; i < NumTypes; ++i)
-        if(tagTypeText(static_cast<TagType>(i), false) == text)
+        if(tagTypeText(static_cast<TagType>(i)) == text)
             return static_cast<TagType>(i);
 
     return Unknown;


_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]