[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    [Bug 154718] kdemultimedia doesn't build on NetBSD
From:       Michael Pyne <mpyne () purinchu ! net>
Date:       2008-01-03 9:06:02
Message-ID: 20080103090602.20811.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154718         
mpyne purinchu net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1



------- Additional Comments From mpyne purinchu net  2008-01-03 10:06 -------
I agree with the cdda.c patch

As far as plat_freebsd.c I don't think it requires a CMake check as it's something \
that gcc can just as easily check.  I would remove the _H from HAVE_SYS_STATVFS_H as \
you're looking for the function, not the header (unless you implement a CMake check \
looking for the header).

I think it would be cleaner to do something along the lines of

#ifdef HAVE_SYS_STATVFS

#define stat_fn fstatvfs
#define statvfs_t struct statvfs

#else

#define stat_fn fstatfs
#define statvfs_t struct statfs

#endif

and then use the type and function in gen_eject() but I suppose it's ugly macros \
either way so take your pick.  I'll agree with the patch either version (but man this \
needs to get ported to Solid or something! ;)

Mark, do you have an svn account or does someone else need to commit?
_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]