[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    [PATCH] kaudiocreator : cddb dialog not displaying correctly
From:       Chris Gow <sniffy () rogers ! com>
Date:       2007-01-27 1:16:45
Message-ID: 200701262016.46034.sniffy () rogers ! com
[Download RAW message or body]

Hello:

Please find attached a patch that fixes the CDInfoDialog not displaying 
correctly in kaudiocreator in trunk. The patch applies to 
kmultimedia/kaudiocreator/tracksimp.cpp. 

Currently kaudiocreator attempts to add the CDInfoDialog to another KDialog 
which is not possible. This patch uses the CDInfoDialog class as the dialog 
to display.

On my system, the dialog does not open to the correct size, however in email 
correspondence with other KDE developers 
(http://lists.kde.org/?l=kde-devel&m=116949417414317&w=2), I believe this 
might be a problem local to my environment.


thanks

-- chris

["fix_kaudiocreator_cdinfodialog.patch" (text/x-diff)]

Index: tracksimp.cpp
===================================================================
--- tracksimp.cpp	(revision 626931)
+++ tracksimp.cpp	(working copy)
@@ -291,24 +291,22 @@ void TracksImp::lookupCDDBDone(CDDB::Res
 void TracksImp::editInformation( ) {
 	if( !hasCD() ) return;
 	// Create dialog.
-	KDialog *dialog = new KDialog( this );
+	CDInfoDialog *dialog = new CDInfoDialog( this );
 	dialog->setModal(false);
 	dialog->setCaption(i18n( "CD Editor" ));
 	dialog->setButtons(KDialog::Ok|KDialog::Cancel);
 	dialog->setDefaultButton(KDialog::Ok);
 	dialog->showButtonSeparator(true);
 
-	CDInfoDialog *base = new CDInfoDialog(dialog);
 	// Workaround the fact that CDInfoDialog doesn't take
 	// a const TrackOffsetList
 	QList<unsigned> discSig = cd->discSignature();
-	base->setInfo(cddbInfo, discSig);
-	dialog->setMainWidget(base);
+	dialog->setInfo(cddbInfo, discSig);
 
 	// Show dialog->and save results.
 	bool okClicked = dialog->exec();
 	if( okClicked ) {
-		cddbInfo = base->info();
+		cddbInfo = dialog->info();
 		newAlbum();
 		cddb->store(cddbInfo);
 	}


_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]