[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: patch: normalize effect for noatunarts
From:       Felix Berger <bflat1 () gmx ! net>
Date:       2005-01-02 23:27:48
Message-ID: 200501030027.48711.bflat1 () gmx ! net
[Download RAW message or body]

On Sunday 02 January 2005 19:36, Stefan Westerfeld wrote:

> $ artsshell tradercheck
>
> to print warnings is not a good idea (however, one can't say that
> everybody cares about this rule...). If the feature to show/hide certain
> effects is wanted for noatun (or other apps), one clean way to go might
> be adding a new flag entry into .mcopclass files similar to for instance
> the already existing "Buildable" entry (artsbuilder uses this to
> determine which modules to show).

Thanks for pointing that out. I've attached my corrected Normalize.mcopclass, 
which also introduces a visibility property. I've also attached the patch for 
effects.cpp that checks if an effect has explicitly set the property to 
false. The default is true.

I can also correct the other mcopclass files, if this patch is applied.

Right now it looks like this on my system:

 artsshell tradercheck
...
Trader inconsistency in 'NoatunArts::EqualizerSSE':
 * missing interface Arts::SynthModule in Interface entry
Trader inconsistency in 'NoatunArts::FFTScope':
 * missing interface Arts::SynthModule in Interface entry
Trader inconsistency in 'NoatunArts::FFTScopeStereo':
 * missing interface Arts::SynthModule in Interface entry
Trader inconsistency in 'NoatunArts::RawScope':
 * missing interface Arts::SynthModule in Interface entry
Trader inconsistency in 'NoatunArts::RawScopeStereo':
 * missing interface Arts::SynthModule in Interface entry
Trader inconsistency in 'NoatunArts::StereoEffectStack':
 * missing interface Arts::SynthModule in Interface entry
Trader inconsistency in 'NoatunArts::StereoVolumeControl':
 * missing interface Arts::SynthModule in Interface entry
Trader inconsistency in 'NoatunArts::StereoVolumeControlSSE':
 * missing interface Arts::SynthModule in Interface entry

Felix

-- 
Use Debian GNU/Linux!
http://www.felix.beldesign.de/

["Normalize.mcopclass" (text/plain)]

Interface=NoatunArts::Normalize,Arts::StereoEffect,Arts::SynthModule,Arts::Object
Language=C++
Library=libnoatunarts.la
Visible=false
["visibility.diff" (text/x-diff)]

Index: effects.cpp
===================================================================
RCS file: /home/kde/kdemultimedia/noatun/library/effects.cpp,v
retrieving revision 1.30
diff -u -b -B -d -w -U5 -r1.30 effects.cpp
--- effects.cpp	6 Oct 2004 11:03:14 -0000	1.30
+++ effects.cpp	2 Jan 2005 23:25:17 -0000
@@ -248,13 +248,17 @@
 	query.supports("Interface", "Arts::SynthModule");
 	vector<Arts::TraderOffer> *offers = query.query();
 	for (vector<Arts::TraderOffer>::iterator i=offers->begin(); i!=offers->end(); i++)
 	{
 		Arts::TraderOffer &offer=*i;
+		vector<string>* visible = offer.getProperty("Visible");
+		if (visible->empty() || visible->front() == "true") {
 		QCString name = offer.interfaceName().c_str();
 		val.append(name);
 	}
+		delete visible;
+	}
 	delete offers;
 	return val;
 }
 
 Effect *Effects::findId(long id) const


_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]