[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    patch for kmix kicker applet
From:       Koos Vriezen <koos.vriezen () xs4all ! nl>
Date:       2004-06-30 19:21:08
Message-ID: 20040630192108.GA32575 () xs4all ! nl
[Download RAW message or body]

Hi,

Latest CVS version kmix applet crashes when adding to kicker:

[KCrash handler]
#4  0x4153eae8 in QGList::first ()
   from /mnt/hda7/local/koos/kde/cvsup/qt-copy/lib/libqt-mt.so.3
#5  0x40b962f0 in KMixApplet::setColors ()
   from /opt/kde-cvs/kde3/lib/kde3/kmix_panelapplet.so
#6  0x40b9618c in KMixApplet::paletteChange ()
   from /opt/kde-cvs/kde3/lib/kde3/kmix_panelapplet.so
#7  0x412be326 in QWidget::setPalette ()
   from /mnt/hda7/local/koos/kde/cvsup/qt-copy/lib/libqt-mt.so.3
#8  0x412be097 in QWidget::setPaletteBackgroundPixmap ()
   from /mnt/hda7/local/koos/kde/cvsup/qt-copy/lib/libqt-mt.so.3
#9  0x409bb29c in AppletProxy::process ()
   from /opt/kde-cvs/kde3/lib/libkdeinit_appletproxy.so
#10 0x408dc0d6 in DCOPClient::receive ()
   from /opt/kde-cvs/kde3/lib/libDCOP.so.4
#11 0x408d51cd in DCOPProcessInternal ()
   from /opt/kde-cvs/kde3/lib/libDCOP.so.4
#12 0x408d4b6c in DCOPProcessMessage () from /opt/kde-cvs/kde3/lib/libDCOP.so.4
#13 0x408e6b5e in KDE_IceProcessMessages ()
   from /opt/kde-cvs/kde3/lib/libDCOP.so.4
#14 0x408ddbd5 in DCOPClient::processSocketData ()
   from /opt/kde-cvs/kde3/lib/libDCOP.so.4

This fixes it for me:

diff -u -3 -p -r1.57 kmixapplet.cpp
--- kmixapplet.cpp      24 Jun 2004 08:53:15 -0000      1.57
+++ kmixapplet.cpp      30 Jun 2004 19:17:51 -0000
@@ -507,7 +507,7 @@ void KMixApplet::applyPreferences()
 }

 void KMixApplet::paletteChange ( const QPalette &) {
-    if ( ! _customColors ) {
+    if ( ! _customColors && m_mixerWidget ) {
        // We take over Colors from paletteChange(), if the user has not set custom colors.
        // ignore the given QPalette and use the values from KGlobalSettings instead
        _colors.high = KGlobalSettings::highlightColor();

After this fix, the applet first showed 'Choose mixer', I guess that's why
it's unnoticed.. Can someone apply this one?

Regards,

Koos Vriezen
_______________________________________________
kde-multimedia mailing list
kde-multimedia@kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]