[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Ogg kfile-plugin should respect the hints
From:       Carsten Pfeiffer <carpdjih () mailbox ! tu-berlin ! de>
Date:       2002-12-31 14:24:35
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----

On Tuesday 31 December 2002 14:20, Ismael Orenstein wrote:

> The problem is that the ogg kfile-plugin doesn't use all of this hints. At
> least it doesn't use the Author and Name ones. I know that the Ogg format
> gives enough freedom so that any key can be used (instead of mp3 id3, which
> has a fixed field for the artist and name). However, some keys are
> standardized by the vorbis spec... shouldn't the hint point to these keys
> at least?
[...]
> It is just a matter of adding, near line 78 of kfile_ogg.cpp, something
> like that:
>
> item = addItemInfo(group, "Artist", i18n("Artist"), QVariant::String);
> setHint(item, KFileMimeTypeInfo::Author);
>
> item = addItemInfo(group, "Title", i18n("Title"), QVariant::String);
> setHint(item, KFileMimeTypeInfo::Name);

Added, thanks. Please point out any other problems you may find.

Cheers
Carsten Pfeiffer
-----BEGIN PGP SIGNATURE-----

iQEVAwUBPhGoo6WgYMJuwmZtAQFdSAf/eg//i0MeIfQKLGLHahEHVYinr3JRv9HF
ZSECkxA/DlQw0NtJ3xX2xA+YdPRMdpB+CwC7Cy3XZw9lNyAMyw3BJjdkGva3w4zz
Fz35nF+X9XUeltWvlD2l8a1NSG2MyarHDacPPDVicaBSQ4+KKyqiCM/X8NL5S5H2
qWKSAbseJ0+h/of8P39h2UY26P1mWKmx8ZkSCJkRRcRyBr3IUuVZaw1ID3zvgq41
iARvcuzuiSgIBnl5rlkayHCVTbaPu1WkZ5iuOFqwMMtdBXu+zJH6L9yfkJtxZRaH
ONakGz80aslpR3uZQvnGManLAc+NGD8+Tzx3wcUycZXwEw0r7ETh/w==
=igK2
-----END PGP SIGNATURE-----

_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]