From kde-multimedia  Sat Nov 09 00:48:16 2002
From: Luis Pedro Coelho <luis_pedro () netcabo ! pt>
Date: Sat, 09 Nov 2002 00:48:16 +0000
To: kde-multimedia
Subject: [PATCH] A proposal for bug 45352
X-MARC-Message: https://marc.info/?l=kde-multimedia&m=103680300811287
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_QtFz9YVCxB8q7tp"


--Boundary-00=_QtFz9YVCxB8q7tp
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

Hi,

{ Relevant Bug at http://bugs.kde.org/show_bug.cgi?id=45352. I had mailed 
rik@kde.org a while back, but got no answer. Assuming he is too busy at the 
moment or that he is wrongly listed as "assigned to",  I am posting this 
here. }

While the long term solution to this will be to change the kcontrol module to 
support quality based encoding. Before 3.1, I think we should at least 
sync both the kcontrol module and the rest of the code.

HTH.
-- 
Luis Pedro Coelho

http://blogs.salon.com/0001523

--Boundary-00=_QtFz9YVCxB8q7tp
Content-Type: text/x-diff;
  charset="us-ascii";
  name="patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="patch"

? patch
Index: audiocd.cpp
===================================================================
RCS file: /cvs/kdemultimedia/kioslave/audiocd/audiocd.cpp,v
retrieving revision 1.59
diff -u -3 -p -r1.59 audiocd.cpp
--- audiocd.cpp	2002/10/13 02:03:06	1.59
+++ audiocd.cpp	2002/10/27 04:47:07
@@ -1705,7 +1705,12 @@ void AudioCDProtocol::getParameters() {
 
   config->setGroup("Vorbis");
 
-  d->vorbis_encode_method = config->readNumEntry("encmethod", 0); // 0 for quality, 1 for managed bitrate
+  d->vorbis_encode_method = config->readNumEntry("encmethod", 1); // 0 for quality, 1 for managed bitrate
+  // FIXME:
+  // the encmethod is, by default, 1 because that's what the kcm module
+  // supports now (late Oct 2002). Review this after the kcm gets fixed to
+  // support encmethod 0
+ 
   d->vorbis_quality = config->readDoubleNumEntry("quality",3.0); // default quality level of 3, to match oggenc
 
   if ( config->readBoolEntry("set_vorbis_min_bitrate",false) ) {

--Boundary-00=_QtFz9YVCxB8q7tp--

_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia