[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Arts causing memory corruption
From:       Matthias Welwarsky <matze () stud ! fbi ! fh-darmstadt ! de>
Date:       2002-11-02 18:39:56
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On Tuesday 29 October 2002 11:55, Dirk Mueller wrote:
> Hi,
>
> I regularly see crashes caused by arts:
>
> ==9739== Invalid read of size 1
> ==9739==    at 0x49F8FAC7: magic_create (../../../flow/gsl/gslmagic.c:440)
> ==9739==    by 0x49F8F340: gsl_magic_create
> (../../../flow/gsl/gslmagic.c:148)

Could you confirm that the attached patch fixes the first one? Did you file a 
bug report? Which Id?

> and
>
> ==9739== Invalid read of size 4
> ==9739==    at 0x4A7F6F10: Arts::Dispatcher::connectUrl(std::string const&)
> (../../mcop/dispatcher.cc:926)
> ==9739==    by 0x4A7F6DAD:
> Arts::Dispatcher::connectObjectRemote(Arts::ObjectReference&)
> (/usr/include/g++/bits/stl_iterator.h:593)
> ==9739==    by 0x49D99DEB:

Could you tell me how to reproduce this one?

regards,
	matze

-- 
Matthias Welwarsky
Fachschaft Informatik FH Darmstadt
Email: matze@stud.fbi.fh-darmstadt.de

"all software sucks equally, but some software is more equal"

["gslmagic.c.patch" (text/x-diff)]

Index: gslmagic.c
===================================================================
RCS file: /home/kde/arts/flow/gsl/gslmagic.c,v
retrieving revision 1.2
diff -u -3 -p -r1.2 gslmagic.c
--- gslmagic.c	2002/05/17 17:44:09	1.2
+++ gslmagic.c	2002/11/02 18:37:58
@@ -395,9 +395,10 @@ magic_parse_offset (Magic *magic,
 static Magic*
 magic_create (gchar       *magic_string,
 	      const gchar *original)
+#define SKIP_CLEAN(s)	{ while (*s && !strchr(magic_field_delims, *s)) s++; \
+                          while (*s && strchr(magic_field_delims, *s)) \
+                            *(s++)=0;}
 {
-#define SKIP_CLEAN(s)	{ while (*s && !strchr (magic_field_delims, *s)) s++; \
-                          do *(s++) = 0; while (strchr (magic_field_delims, *s)); }
   Magic *magics = NULL;
   gchar *p = magic_string;
   

[Attachment #6 (application/pgp-signature)]
_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]