[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Patch for missing translations in noatun
From:       Stefan =?iso-8859-1?q?Asserh=E4ll?= <stefan.asserhall () telia ! com>
Date:       2002-07-23 22:57:37
[Download RAW message or body]

Hi,

Here is a patch for translations of equalizer presets not being shown,
that fixes the problem for me. I also noticed that preset.eclecticguitar 
was not installed. A mistake?

Can I commit this patch to CVS?

I've already applied three other similar (but trivial) patches:
1. Finding noatun plugin files in kdeaddon for desktop.pot
2. Added "*.ui" to noatun/Makefile.am for translation
3. Added "i18n" to noatun/modules/simple/userinterface.cpp

The only remaining i18n problem in noatun that I know of, is that 
effects and their configuration dialogs are not translated. This is 
pretty hard to do, since the strings come from arts (where nothing is
translated). For "known" effects, it could be fixed with I18N_NOOP, 
similar to what is done for the equalizer presets. I can implement 
that, if agreed.

I'm not subscribed to the list, so please CC me.

/ Stefan Asserhäll

["noatun2.diff" (text/x-diff)]

Index: Makefile.am
===================================================================
RCS file: /home/kde/kdemultimedia/noatun/Makefile.am,v
retrieving revision 1.9
diff -u -3 -p -r1.9 Makefile.am
--- Makefile.am	23 Jul 2002 15:38:35 -0000	1.9
+++ Makefile.am	23 Jul 2002 22:17:19 -0000
@@ -25,7 +25,7 @@ applnk_DATA = noatun.desktop
 applnkdir = $(kde_appsdir)/Multimedia
 
 presetsdir = $(kde_datadir)/noatun/eq.preset
-presets_DATA = preset.dance preset.jazz preset.metal preset.trance preset.zero
+presets_DATA = preset.dance preset.jazz preset.metal preset.trance preset.zero preset.eclecticguitar
 
 updatedir = $(kde_datadir)/kconf_update
 update_DATA = noatun.upd
Index: library/equalizer.cpp
===================================================================
RCS file: /home/kde/kdemultimedia/noatun/library/equalizer.cpp,v
retrieving revision 1.20
diff -u -3 -p -r1.20 equalizer.cpp
--- library/equalizer.cpp	3 May 2002 18:30:08 -0000	1.20
+++ library/equalizer.cpp	23 Jul 2002 22:17:19 -0000
@@ -57,7 +57,7 @@ QString Preset::name() const
 
 	QDomElement docElem = doc.documentElement();
 	if (docElem.tagName()!="noatunequalizer") return 0;
-	bool standard=docElem.attribute("default", "0")=="0";
+	bool standard=docElem.attribute("default", "0")=="1";
 	QString n=docElem.attribute("name", 0);
 
 	{ // All the translations for the presets

_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]