[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: bug in noatuntags ? pure virtual method being called
From:       Charles Samuels <charles () kde ! org>
Date:       2002-05-22 5:45:26
[Download RAW message or body]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

tirsdag 21 mai 2002, 07:38 pm, skrev Ismael Orenstein:
> Hey there!
>
> I think I've found a bug in noatun/library/noatuntags. The PlaylistNotifier
> class, which TagsGetter inherits, has a pure virtual modified() method,
> which isn't implemented by this class. That isn't a big problem, if
> PlaylistItemData::modified() didn't call the modified() method for all the
> PlaylistNotifiers. The result: a SIGABRT that I found fairly hard to trace
> in the playlist plugin I'm writing.
>
> The attached patch fixes it, at least for my case... please review it (I
> don't know if this implementation for TagsGetter::modified() is a good
> one... I couldn't think of anything better and I don't know the TagsGetter
> code well enough to do anything more bold than that... :) )

Well, I'm reading the PlaylistNotifier code now.

    /**
     * this item was modified (via a changed
     * or added property
     **/
    virtual void modified(PlaylistItem &) {}

Doesn't look very pure to me.  I havn't encountered this SIGABRT program, but 
I believe you when you say you got it :)

perhaps you could LD_PRELOAD a function with
extern "C" __pure_virtual()
{
	volatile int x=1;
	while (x) sleep();
}



- -- 
Charles Samuels <charles@kde.org>
Conversvatism is Conformity
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE86zB8WS4Pv66UcxkRAvGgAKCn5dQ6l/1TQf9x3r94C1DJlIalYwCgwjF2
2wPxiWGV6mhc/0LrGWMaF04=
=uMj6
-----END PGP SIGNATURE-----

_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia
[prev in list] [next in list] [prev in thread] [next in thread]