[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Bug#39662: noatun can't save/load utf8 playlist correctly
From:       Takumi ASAKI <asataku () osk3 ! 3web ! ne ! jp>
Date:       2002-03-23 0:00:43
[Download RAW message or body]

Neil Stevens wrote:

>I'd say this is almost the right fix, but in the wrong place.  I'd have the
>*user* of the KSaver do
>saver.textStream().setEncoding(QTextStream::UnicodeUTF8).

>Probably a good idea for the splitplaylist to use utf8, since KDE now
>has support for utf8 filenames.  People will expect the filenames to
>appear correctly.

I agree I write new patch.
Please destory old patch.
It fix codec for splitplaylist.xml.

I don't take care M3U saver/loader.
It use locale-codec.

Please review it.

Thanks.

-- 
  Che Che - Bye Bye
        From: Takumi ASAKI <asataku@osk3.3web.ne.jp>
	URL: http://www3.osk.3web.ne.jp/~asataku/

["kdemultimedia-3.0-cvs-noatun-playlist-i18n-20020323.diff" (text/x-diff)]

diff -ur kdemultimedia.orig/noatun/library/playlistsaver.cpp \
                kdemultimedia/noatun/library/playlistsaver.cpp
--- kdemultimedia.orig/noatun/library/playlistsaver.cpp	Tue Mar 19 01:05:43 2002
+++ kdemultimedia/noatun/library/playlistsaver.cpp	Sat Mar 23 08:53:59 2002
@@ -130,6 +130,9 @@
 	Noatun::KSaver saver(local);
 	if (!saver.open())
 		return false;
+	// set saver's encoding to latin1.
+	// not UnicodeUTF8. because doc is already utf8.
+	saver.textStream().setEncoding(QTextStream::Latin1);
 	saver.textStream() << doc.toString();
 	saver.close();
 


_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]