[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Re: Problem with Noatun's tag loading scheme
From:       Ryan Cumming <bodnar42 () phalynx ! dhs ! org>
Date:       2002-03-10 19:03:57
[Download RAW message or body]

On March 10, 2002 10:48, Ryan Cumming wrote:
> I think that Noatun should always call all tag loaders, in order from
> lowest priority to highest. Some tag loaders may be able to load properties
> that all the other tag loaders know nothing about, and just because a
> higher priority tag loader was satisfied, doesn't mean the lower priority
> ones shouldn't try to load their obscure tags.
>
> Oh, and luckytag should have a lower priority than metatag, for sure. What
> does everyone else think?

Here are two patches that do what I describe. The first one makes Noatun 
continue to try tag loaders, even if one of them returns true. The second one 
makes LuckyTag use a priority of -10. I have no idea what made it think it 
was more important than "authoritive" tag loaders.

Works fine here, and now even Lucky-Tagged files are having their bitrate set 
correctly. If there are no objects I will apply.

-Ryan 
["always-load.diff" (text/x-diff)]

Index: library/noatuntags/tags.cpp
===================================================================
RCS file: /home/kde/kdemultimedia/noatun/library/noatuntags/tags.cpp,v
retrieving revision 1.8
diff -u -r1.8 tags.cpp
--- library/noatuntags/tags.cpp	2002/03/10 08:23:18	1.8
+++ library/noatuntags/tags.cpp	2002/03/10 18:55:50
@@ -66,7 +66,6 @@
 			item.setProperty("Tags::tagged_", "1");
 			if (item==napp->player()->current())
 				napp->player()->handleButtons();
-			break;
 		}
 	}
 
@@ -84,7 +83,6 @@
 		{
 			item.setProperty("Tags::tagged_", "1");
 			napp->player()->handleButtons();
-			break;
 		}
 	}
 	items.remove(item);

["lower-lucky-prio.diff" (text/x-diff)]

Index: luckytag/luckytag.cpp
===================================================================
RCS file: /home/kde/kdeaddons/noatun-plugins/luckytag/luckytag.cpp,v
retrieving revision 1.7
diff -u -r1.7 luckytag.cpp
--- luckytag/luckytag.cpp	2002/01/22 02:32:09	1.7
+++ luckytag/luckytag.cpp	2002/03/10 18:56:26
@@ -28,7 +28,7 @@
 	return new LuckyTagger;
 }
 
-LuckyTagger::LuckyTagger(void) : Tags(10)
+LuckyTagger::LuckyTagger(void) : Tags(-10)
 {
 }
 

_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia

[prev in list] [next in list] [prev in thread] [next in thread]