[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-multimedia
Subject:    Bug#36303: Gui stuff.
From:       Thomas Zander <zander () planescape ! com>
Date:       2001-12-28 13:03:58
[Download RAW message or body]

On Wed, Dec 19, 2001 at 01:06:31PM -0800, Neil Stevens wrote:
> On Wednesday December 19, 2001 12:08, Thomas Zander wrote:
> > - in the effects dialog the 'remove effect' icon is a close icon.
> > It should be the remove icon (the red cross on a piece of paper)
> 
> Can you commit this yourself, since you seem to know which icon is 
> preferred.  Thanks

I mean the one splitplaylist uses in the mDelete KAction; no idea how
to get that icon visible in the effects dialog; I was expecting KActions
there but you used something else.
kdemultimedia/noatun/modules/splitplaylist/view.cpp line:487
  mDelete=new KAction(i18n("Delete"), "editdelete", Qt::Key_Delete, this, \
SLOT(deleteSelected()), this, "delete")

> > - the window-close icon of (at least) the excellent skin
> > closes the application as pointed out before this is not correct and not
> > according to the styleguide, yet you choose to change it again. ???
> > Maybe you don't respect the styleguide ?
> 
> See my comments in that thread.  The styleguide, in that section, only 
> addresses document-centered apps, and the distinction between close and 
> quit made there makes absolutely no sense in the context of noatun.  I 
> would suggest that in non-document apps, like noatun or ksirc, Close 
> doesn't belong in a controller window, and Quit should quit the app like 
> the standard says.
> 
> Furthermore, the styleguide certainly does Not say that applications 
> should act differently because they have an optional systray icon, that I 
> saw.
> 

Well, noatun is about the only application that does it differently from
the rest (kicq/kmix/klipper/kmoon etc) so there was no need for an extra 
section in the styleguide as everyone did it the same without explicit rules.

Please then use the new specific systray rules in the styleguide.
 http://developer.kde.org/documentation/standards/kde/style/basics/systray.html
Thanx.

-- 
Thomas Zander                                            zander@earthling.net
The only thing worse than failure is the fear of trying something new
_______________________________________________
kde-multimedia mailing list
kde-multimedia@mail.kde.org
http://mail.kde.org/mailman/listinfo/kde-multimedia


[prev in list] [next in list] [prev in thread] [next in thread]