[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: Review Request 129289: small tweaks for building on Mac
From: Stephane Mankowski <stephane () mankowski ! fr>
Date: 2019-04-07 11:44:41
Message-ID: 20190407114441.1423.90709 () mimi ! kde ! org
[Download RAW message or body]
--===============0009835826120022456==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129289/#review103876
-----------------------------------------------------------
Sorry, I'm just discovering this review.
I commited the proposed corrections.
Thank you for your contribution to improve Skrooge.
- Stephane Mankowski
On oct. 30, 2016, 5:06 après-midi, René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129289/
> -----------------------------------------------------------
>
> (Updated oct. 30, 2016, 5:06 après-midi)
>
>
> Review request for KDE Software on Mac OS X and Skrooge.
>
>
> Repository: skrooge
>
>
> Description
> -------
>
> This patch provides a few small tweaks to improve the Mac build:
>
> - build skroogeconvert as a regular ("nongui") executable instead of an app bundle
> - generate a multi-scale icon from all png icons size 256px and smaller
> - prevent runtime discarding of the app icon if icon-from-theme lookup doesn't work (which it doesn't \
> by default on OS X)
>
> Diffs
> -----
>
> skrooge/CMakeLists.txt 03bc220
> skrooge/main.cpp c49fec7
> skroogeconvert/CMakeLists.txt 28b4901
>
>
> Diff: https://git.reviewboard.kde.org/r/129289/diff/1/
>
>
> Testing
> -------
>
> Works as intended on OS X 10.9.5 with Qt 5.6.1 and KF5 5.27.0
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============0009835826120022456==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129289/">https://git.reviewboard.kde.org/r/129289/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Sorry, I'm just discovering this review. I commited the proposed \
corrections. Thank you for your contribution to improve Skrooge.</p></pre>
<br />
<p>- Stephane Mankowski</p>
<br />
<p>On octobre 30th, 2016, 5:06 après-midi UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and Skrooge.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><em>Updated oct. 30, 2016, 5:06 après-midi</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
skrooge
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch provides a few small tweaks to \
improve the Mac build:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: \
inherit;white-space: normal;"> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;">build skroogeconvert as a regular ("nongui") executable instead of an app \
bundle</li> <li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">generate a multi-scale icon from all png icons size 256px and smaller</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">prevent runtime discarding \
of the app icon if icon-from-theme lookup doesn't work (which it doesn't by default on OS X)</li> \
</ul></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Works as intended on OS X 10.9.5 with Qt \
5.6.1 and KF5 5.27.0</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>skrooge/CMakeLists.txt <span style="color: grey">(03bc220)</span></li>
<li>skrooge/main.cpp <span style="color: grey">(c49fec7)</span></li>
<li>skroogeconvert/CMakeLists.txt <span style="color: grey">(28b4901)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129289/diff/1/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0009835826120022456==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic