[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-pim
Subject: Re: Review Request 119533: Make ktimetracker build on OS X, where it uses a native method from the A
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2017-11-13 21:42:06
Message-ID: 20171113214206.6226.9503 () mimi ! kde ! org
[Download RAW message or body]
--===============0085961854887076730==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119533/
-----------------------------------------------------------
(Updated nov. 13, 2017, 9:42 après-midi)
Status
------
This change has been discarded.
Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.
Repository: kdepim
Description
-------
Signed-off-by: RJVB <rjvbertin@gmail.com>
Diffs
-----
CMakeLists.txt.orig d12b90a
ktimetracker/CMakeLists.txt bf7b0ef41d851055359dc2cdcb2d2d3cbce25a6d
ktimetracker/idletimedetector.h 524f739e89a77d1dbd732af8f258b3276e994eba
ktimetracker/idletimedetector.cpp 250dda55582f53cfc44242582dee7e07062f5358
ktimetracker/ktimetrackerutility.cpp efeba3abdc94a3725f0e0d6a9b663959a06dcc1f
ktimetracker/mainwindow.cpp 56d4c286213507490b31fb131f1097a4c00b7abe
Diff: https://git.reviewboard.kde.org/r/119533/diff/2/
Testing
-------
Testing was done under KDE and KDEPIM 4.12.5, MacPorts. The patches from that version \
applied without issues on the code in git, with 2 exceptions that I could re-apply \
manually easily.
With these patches, ktimetracker builds and launches under OS X (•) and loads \
existing ktimetracker.ics files correctly. The idle time detection feature appears to \
work as far as I'm able to tell (I don't use it under Linux).
What remains to be done is to double-check the timing precision: I've had an \
impression that timing may be too fast but haven't been able to prove timing isn't \
correct.
The history output to clipboard feature does ignore the date range and "output only \
the selection" options; removing entries originating from Linux we have
"test" 0.00 0.00
"test->test 1" 0.07 0.03
"test->test 2" 0.00 0.06
"test->test 3" 0.00 0.03
"test->test 4" 0.00 0.03
and the timing output (which does honour the "output only the selection" option):
Totaux des tâches
20140729 13:09
Durée Tâche
----------------------------------------------
0:12 test
0:05 test 1
0:03 test 2
0:02 test 3
0:02 test 4
----------------------------------------------
0:12 Total
•) this supposes libical is installed and built following \
https://trac.macports.org/ticket/44469, i.e. using cmake instead and including a \
patch from Ubuntu.
Thanks,
René J.V. Bertin
--===============0085961854887076730==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119533/">https://git.reviewboard.kde.org/r/119533/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDEPIM and Thorsten Staerk.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><em>Updated nov. 13, 2017, 9:42 après-midi</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
kdepim
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Signed-off-by: RJVB <rjvbertin@gmail.com></p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Testing was done under KDE and KDEPIM 4.12.5, \
MacPorts. The patches from that version applied without issues on the code in git, \
with 2 exceptions that I could re-apply manually easily.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With \
these patches, ktimetracker builds and launches under OS X (•) and loads existing \
ktimetracker.ics files correctly. The idle time detection feature appears to work as \
far as I'm able to tell (I don't use it under Linux).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What \
remains to be done is to double-check the timing precision: I've had an impression \
that timing may be too fast but haven't been able to prove timing isn't correct.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The history output to clipboard feature does ignore \
the date range and "output only the selection" options; removing entries originating \
from Linux we have</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">"test" 0.00 0.00 "test->test 1" \
0.07 0.03 "test->test 2" 0.00 0.06
"test->test 3" 0.00 0.03
"test->test 4" 0.00 0.03</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">and the timing output (which does honour the "output \
only the selection" option):</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Totaux des tâches 20140729 13:09</p>
<h2 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">Durée Tâche</h2> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">0:12 \
test 0:05 test 1
0:03 test 2
0:02 test 3
0:02 test 4</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: \
1px solid #ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">0:12 Total</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">•) this supposes libical is installed and built following \
https://trac.macports.org/ticket/44469, i.e. using cmake instead and including a \
patch from Ubuntu.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt.orig <span style="color: grey">(d12b90a)</span></li>
<li>ktimetracker/CMakeLists.txt <span style="color: \
grey">(bf7b0ef41d851055359dc2cdcb2d2d3cbce25a6d)</span></li>
<li>ktimetracker/idletimedetector.h <span style="color: \
grey">(524f739e89a77d1dbd732af8f258b3276e994eba)</span></li>
<li>ktimetracker/idletimedetector.cpp <span style="color: \
grey">(250dda55582f53cfc44242582dee7e07062f5358)</span></li>
<li>ktimetracker/ktimetrackerutility.cpp <span style="color: \
grey">(efeba3abdc94a3725f0e0d6a9b663959a06dcc1f)</span></li>
<li>ktimetracker/mainwindow.cpp <span style="color: \
grey">(56d4c286213507490b31fb131f1097a4c00b7abe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119533/diff/2/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0085961854887076730==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic