[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: Review Request 127638: build system option to build "kdev-clang" and the rest of the IDE separat
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2017-01-09 12:15:49
Message-ID: 20170109121549.30286.86568 () mimi ! kde ! org
[Download RAW message or body]
--===============3668692624321872083==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127638/
-----------------------------------------------------------
(Updated Jan. 9, 2017, 1:15 p.m.)
Status
------
This change has been discarded.
Review request for KDE Software on Mac OS X and KDevelop.
Repository: kdevelop
Description
-------
This patch is in reaction to a discussion on kdevelop-devel about weakening \
KDevelop's dependency on a specific Clang (libclang) version.
The patch introduces 2 CMake options:
- `KDEVELOP_BUILD_IDE` builds just the IDE, without the clang-based parser (formerly \
kdev-clang)
- `KDEVELOP_BUILD_CLANG_PARSER` builds just the clang-based parser
Nothing changes when both options are on (the default): all of KDevelop is built. \
When both options are off, an error is raised.
The idea is that this should make it a little bit easier for distributions/packaging \
systems and users to change the clang toolchain.
I presume that the languages subdirectory could be built first or last (that would \
the patch a bit simpler)?
Diffs
-----
CMakeLists.txt 2d3faa7
languages/CMakeLists.txt 4e2fde2
languages/clang/CMakeLists.txt c19a951
Diff: https://git.reviewboard.kde.org/r/127638/diff/
Testing
-------
On OS X and Linux, against Qt 5.6.0, FWs 5.20.0, prefix=/opt/local
Thanks,
René J.V. Bertin
--===============3668692624321872083==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127638/">https://git.reviewboard.kde.org/r/127638/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDevelop.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2017, 1:15 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevelop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch is in reaction to a discussion on \
kdevelop-devel about weakening KDevelop's dependency on a specific Clang (libclang) \
version.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The patch introduces 2 CMake options:
- <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">KDEVELOP_BUILD_IDE</code> builds just the \
IDE, without the clang-based parser (formerly kdev-clang)
- <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">KDEVELOP_BUILD_CLANG_PARSER</code> builds \
just the clang-based parser</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Nothing changes when both options are \
on (the default): all of KDevelop is built. When both options are off, an error is \
raised.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The idea is that this should make it a little bit \
easier for distributions/packaging systems and users to change the clang \
toolchain.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I presume that the languages subdirectory could be \
built first or last (that would the patch a bit simpler)?</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X and Linux, against Qt 5.6.0, FWs 5.20.0, \
prefix=/opt/local</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2d3faa7)</span></li>
<li>languages/CMakeLists.txt <span style="color: grey">(4e2fde2)</span></li>
<li>languages/clang/CMakeLists.txt <span style="color: grey">(c19a951)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127638/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3668692624321872083==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic