[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: Review Request 129778: proposal: make use of KDE file dialogs depend on a build option
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2017-01-05 14:18:24
Message-ID: 20170105141824.13774.73151 () mimi ! kde ! org
[Download RAW message or body]
--===============1435787582964525144==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129778/
-----------------------------------------------------------
(Updated Jan. 5, 2017, 3:18 p.m.)
Review request for KDE Software on Mac OS X and KDevelop Valgrind Plugin.
Repository: kdevplatform
Description (updated)
-------
As discussed on the kdevelop-devel ML ("KDE vs. native/Qt file dialogs"):
This patch introduces a build (CMake) option that allows chosing between the use of \
KDE or platform-native file dialogs, currently in places where the choice isn't \
determine by the platform theme or theme plugin. The option defaults to OFF on MSWin \
and Mac, ON everywhere else (that should catch everything Unix/X11 or Wayland).
Diffs
-----
CMakeLists.txt d8b4e4f
shell/documentcontroller.cpp 203ae2a
shell/openprojectdialog.cpp 84965e3
Diff: https://git.reviewboard.kde.org/r/129778/diff/
Testing
-------
Works as intended for the file dialogs currently under KDE_FULL_SESSION control in \
KDevPlatform. The principle could probably be extended to other file dialogs and a \
flag may need to be set somewhere if this KDevPlatform build setting should apply \
also to building KDevelop (suggestions and participation welcome).
Thanks,
René J.V. Bertin
--===============1435787582964525144==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129778/">https://git.reviewboard.kde.org/r/129778/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDevelop Valgrind Plugin.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Jan. 5, 2017, 3:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdevplatform
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed on the kdevelop-devel ML ("KDE vs. \
native/Qt file dialogs"):</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This patch introduces a build (CMake) \
option that allows chosing between the use of KDE or platform-native file dialogs, \
currently in places where the choice isn't determine by the platform theme or theme \
plugin. The option defaults to OFF on MSWin and Mac, ON everywhere else (that should \
catch everything Unix/X11 or Wayland).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Works as intended for the file dialogs currently under \
KDE_FULL_SESSION control in KDevPlatform. The principle could probably be extended to \
other file dialogs and a flag may need to be set somewhere if this KDevPlatform build \
setting should apply also to building KDevelop (suggestions and participation \
welcome).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d8b4e4f)</span></li>
<li>shell/documentcontroller.cpp <span style="color: grey">(203ae2a)</span></li>
<li>shell/openprojectdialog.cpp <span style="color: grey">(84965e3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129778/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1435787582964525144==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic