[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-mac
Subject:    Re: Review Request 122756: [OS X] buildsystem: find python3 executable and libraries
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2016-12-13 14:46:34
Message-ID: 20161213144634.16852.42088 () mimi ! kde ! org
[Download RAW message or body]

--===============8116063935474134796==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122756/
-----------------------------------------------------------

(Updated Dec. 13, 2016, 3:46 p.m.)


Status
------

This change has been discarded.


Review request for KDE Software on Mac OS X and KDevelop.


Repository: kdev-python


Description
-------

I encountered issues trying to configure kdev-python v1.7.1-py3 on OS X to build \
against MacPorts: the build system didn't pick up the correct Python version.

Someone on the CMake ML pointed me to Python3-specific versions of CMake's FindPython \
modules, and after some adaptation those seem to do the trick.


Diffs
-----

  CMakeLists.txt 18ecfc0 
  cmake/CMakeLists.txt PRE-CREATION 
  cmake/modules/FindPython3Interp.cmake PRE-CREATION 
  cmake/modules/FindPython3Libs.cmake PRE-CREATION 
  parser/CMakeLists.txt 1058d76 

Diff: https://git.reviewboard.kde.org/r/122756/diff/


Testing
-------

On OS X 10.9.5/MacPorts.


Thanks,

René J.V. Bertin


--===============8116063935474134796==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122756/">https://git.reviewboard.kde.org/r/122756/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X and KDevelop.</div>
<div>By René J.V. Bertin.</div>


<p style="color: grey;"><i>Updated Dec. 13, 2016, 3:46 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdev-python
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I encountered issues trying to configure kdev-python \
v1.7.1-py3 on OS X to build against MacPorts: the build system didn't pick up the \
correct Python version.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Someone on the CMake ML pointed me to \
Python3-specific versions of CMake's FindPython modules, and after some adaptation \
those seem to do the trick.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5/MacPorts.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(18ecfc0)</span></li>

 <li>cmake/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/FindPython3Interp.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>cmake/modules/FindPython3Libs.cmake <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>parser/CMakeLists.txt <span style="color: grey">(1058d76)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122756/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8116063935474134796==--


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic