[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 129511: use QSettings::IniFormat everywhere
From: Kåre Särs <kare.sars () iki ! fi>
Date: 2016-11-21 6:53:11
Message-ID: 20161121065311.32069.32059 () mimi ! kde ! org
[Download RAW message or body]
--===============6583171541626281376==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Nov. 20, 2016, 8:33 p.m., Kåre Särs wrote:
> > I think that the decision to go for "ini-format-always" is up to the Sonnet guys, \
> > and then we have to adapt here accordingly. We just read the global setting here \
> > and it has to be the same as Sonnet is using otherwise we only get the default \
> > value.
> > The settings handling in Sonnet is not optimal. The applications can not have \
> > their own private Sonnet settings it is always global :(
> > At one point I was planning to create a patch to expose the Sonnet setting object \
> > so that an application could set it's own private settings, but I never came \
> > around to doing it...
>
> René J.V. Bertin wrote:
> This point already came up in the related Sonnet RR \
> (https://git.reviewboard.kde.org/r/127635/).
> I'm not having much luck until now finding references to the discussion on the ML \
> or to RRs (but one can only search on title here, correct?)
> Kåre Särs wrote:
> A migrating option could be to use QSettings::allKeys() to see if the "ini \
> settings" contains any data and if not read/write the platform standard version on \
> windows and mac. Removing the "old" setting is probably not good when the setting \
> is global... it could have a settings clearing effect on older apps :)
> René J.V. Bertin wrote:
> Eh? The proposition was *not* to use the platform standard version \
> (QSettings::NativeFormat). But yes, in order to do things really properly one would \
> need some form of migration (import using the old format, import using the \
> IniFormat, write as IniFormat).
Yes, only if the new default IniFormat is _empty_, would we check the NativeFormat. \
And use IniFormat after that.
- Kåre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129511/#review100980
-----------------------------------------------------------
On Nov. 20, 2016, 8:10 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129511/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2016, 8:10 p.m.)
>
>
> Review request for Kate, KDE Software on Mac OS X and Kåre Särs.
>
>
> Repository: ktexteditor
>
>
> Description
> -------
>
> A while back already there was a consensus on the frameworks-devel ML (backed by a \
> few related RRs) that it was best to standardise on the `QSettings::IniFormat` to \
> reduce the number of unnecessary platform differences, and to avoid storing \
> settings in the registry on MS Windows.
> I've been running KTextEditor with this patch for almost a year; somehow I forgot \
> to submit it for review until now.
>
> Diffs
> -----
>
> src/utils/kateconfig.cpp 30dd4fe
>
> Diff: https://git.reviewboard.kde.org/r/129511/diff/
>
>
> Testing
> -------
>
> Tested since December 2015 on OS X 10.9.5 .
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============6583171541626281376==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129511/">https://git.reviewboard.kde.org/r/129511/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 20th, 2016, 8:33 p.m. UTC, <b>Kåre \
Särs</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I think that the decision to go for "ini-format-always" is up \
to the Sonnet guys, and then we have to adapt here accordingly. We just read the \
global setting here and it has to be the same as Sonnet is using otherwise we only \
get the default value.
The settings handling in Sonnet is not optimal. The applications can not have their \
own private Sonnet settings it is always global :(
At one point I was planning to create a patch to expose the Sonnet setting object so \
that an application could set it's own private settings, but I never came around \
to doing it...</pre> </blockquote>
<p>On November 20th, 2016, 8:57 p.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
point already came up in the related Sonnet RR \
(https://git.reviewboard.kde.org/r/127635/).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not having much \
luck until now finding references to the discussion on the ML or to RRs (but one can \
only search on title here, correct?)</p></pre> </blockquote>
<p>On November 20th, 2016, 9:20 p.m. UTC, <b>Kåre Särs</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A migrating option could \
be to use QSettings::allKeys() to see if the "ini settings" contains any \
data and if not read/write the platform standard version on windows and mac. Removing \
the "old" setting is probably not good when the setting is global... it \
could have a settings clearing effect on older apps :)</pre> </blockquote>
<p>On November 20th, 2016, 10:11 p.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Eh? \
The proposition was <em style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">not</em> to use the platform standard \
version (QSettings::NativeFormat). But yes, in order to do things really properly one \
would need some form of migration (import using the old format, import using the \
IniFormat, write as IniFormat).</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, only if the new \
default IniFormat is _empty_, would we check the NativeFormat. And use IniFormat \
after that.</pre> <br />
<p>- Kåre</p>
<br />
<p>On November 20th, 2016, 8:10 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate, KDE Software on Mac OS X and Kåre Särs.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Nov. 20, 2016, 8:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ktexteditor
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">A while back already there was a consensus on the \
frameworks-devel ML (backed by a few related RRs) that it was best to standardise on \
the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">QSettings::IniFormat</code> to reduce the \
number of unnecessary platform differences, and to avoid storing settings in the \
registry on MS Windows.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I've been running KTextEditor with this \
patch for almost a year; somehow I forgot to submit it for review until \
now.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested since December 2015 on OS X 10.9.5 .</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/utils/kateconfig.cpp <span style="color: grey">(30dd4fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129511/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6583171541626281376==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic