[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: [KDE/Mac] Review Request 126170: [OS X] make kded5 an agent, and build it as a regular applicati
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2016-06-18 11:06:07
Message-ID: 20160618110607.5478.71606 () mimi ! kde ! org
[Download RAW message or body]
--===============1108101308355258637==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126170/
-----------------------------------------------------------
(Updated June 18, 2016, 4:06 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Software on Mac OS X and KDE Frameworks.
Changes
-------
Submitted with commit 865efa3af8e76db0012acd5da2a24e71231dad84 by René J.V. Bertin \
to branch master.
Repository: kded
Description
-------
There should be no reason to build `kded5` as an app bundle on OS X, and with recent \
feedback in mind I postulated that marking it "nongui" \
(`ecm_mark_nongui_application`) would be acceptable on other platforms too.
Additionally, `kded5` doesn't have any more reason to appear in the Dock or app \
switcher, on OS X, so I have added the code to make it an agent.
Diffs
-----
CMakeLists.txt 72a912c
src/CMakeLists.txt 5e95df8
src/kded.cpp 8e5f7a9
Diff: https://git.reviewboard.kde.org/r/126170/diff/
Testing
-------
On OS X 10.9.5 and Linux with Qt 5.6.1 and FWs 5.22.0 .
File Attachments
----------------
example launchctl plist for auto-starting kded5
https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/ad67bc98-6e43-47c7-9a0a-dbe7b3b8e11f__org.macports.kded5.plist
Thanks,
René J.V. Bertin
--===============1108101308355258637==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126170/">https://git.reviewboard.kde.org/r/126170/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDE Frameworks.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated June 18, 2016, 4:06 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 865efa3af8e76db0012acd5da2a24e71231dad84 by René \
J.V. Bertin to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kded
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">There should be no reason to build <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">kded5</code> as an app bundle on OS X, and with recent \
feedback in mind I postulated that marking it "nongui" (<code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">ecm_mark_nongui_application</code>) would be acceptable on other platforms \
too.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Additionally, <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">kded5</code> doesn't have any more reason to appear in the Dock or app \
switcher, on OS X, so I have added the code to make it an agent.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5 and Linux with Qt 5.6.1 and FWs 5.22.0 \
.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(72a912c)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(5e95df8)</span></li>
<li>src/kded.cpp <span style="color: grey">(8e5f7a9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126170/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/06/18/ad67bc98-6e43-47c7-9a0a-dbe7b3b8e11f__org.macports.kded5.plist">example \
launchctl plist for auto-starting kded5</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1108101308355258637==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic