--===============2089960392343569091== Content-Type: multipart/alternative; boundary="===============5479350698423384513==" --===============5479350698423384513== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128130/#review96302 ----------------------------------------------------------- Ship it! Apparently the gmail spam filter is very good at picking out review requests...... Anyway... I'm certainly fine with disabling an option on mac if it is causing problems. Do you have any idea what's causing this? (And am I correctly understand that this is not a problem on qt5?) - Yichao Yu On 六月 8, 2016, 5:16 p.m., René J.V. Bertin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128130/ > ----------------------------------------------------------- > > (Updated 六月 8, 2016, 5:16 p.m.) > > > Review request for KDE Software on Mac OS X and Yichao Yu. > > > Repository: qtcurve > > > Description > ------- > > Qt4 for Mac OS X has certain shortcomings that can cause rendering artefacts when compositing is used. In QtCurve this can be avoided which made it the preferred widget style for the MacPorts KDE4 ports. > The artefact does occur when using rounded popup menus. Popup menus ought to have rounded corners in order to follow the native style. This works fine under Qt5 but with Qt4 this causes menus to appear empty except under the mouse cursor. > > Since the Qt4 and Qt5 styles share a single preferences file, I propose a patch for qt4/qtcurve.cpp . This makes the code pretend (on OS X) that the "square popup menus" attribute is always set, regardless of the actual setting > > > Diffs > ----- > > qt4/style/qtcurve.cpp 059d906 > > Diff: https://git.reviewboard.kde.org/r/128130/diff/ > > > Testing > ------- > > On OS X 10.9 and Linux, both with Qt 4.8.7 and Qt 5.6.0 > > > Thanks, > > René J.V. Bertin > > --===============5479350698423384513== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128130/

Ship it!

Apparently the gmail spam filter is very good at picking out review requests...... Anyway...

I'm certainly fine with disabling an option on mac if it is causing problems. Do you have any idea what's causing this? (And am I correctly understand that this is not a problem on qt5?)

- Yichao Yu

On 六月 8th, 2016, 5:16 p.m. EDT, René J.V. Bertin wrote:

Review request for KDE Software on Mac OS X and Yichao Yu.

By René J.V. Bertin.

Updated 六月 8, 2016, 5:16 p.m.

Repository: qtcurve

Description

Qt4 for Mac OS X has certain shortcomings that can cause rendering artefacts when compositing is used. In QtCurve this can be avoided which made it the preferred widget style for the MacPorts KDE4 ports. The artefact does occur when using rounded popup menus. Popup menus ought to have rounded corners in order to follow the native style. This works fine under Qt5 but with Qt4 this causes menus to appear empty except under the mouse cursor.

Since the Qt4 and Qt5 styles share a single preferences file, I propose a patch for qt4/qtcurve.cpp . This makes the code pretend (on OS X) that the "square popup menus" attribute is always set, regardless of the actual setting

Testing

On OS X 10.9 and Linux, both with Qt 4.8.7 and Qt 5.6.0

Diffs

qt4/style/qtcurve.cpp (059d906)

--===============5479350698423384513==-- --===============2089960392343569091== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2RlLW1hY0Br ZGUub3JnCkxpc3QgSW5mb3JtYXRpb246IGh0dHBzOi8vbWFpbC5rZGUub3JnL21haWxtYW4vbGlz dGluZm8va2RlLW1hYwpLREUvTWFjIEluZm9ybWF0aW9uOiBodHRwOi8vY29tbXVuaXR5LmtkZS5v cmcvTWFj --===============2089960392343569091==--