'[KDE/Mac] Review Request 128130: [OS X/Qt4] prevent menu rendering artefacts'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-mac
Subject:    [KDE/Mac] Review Request 128130: [OS X/Qt4] prevent menu rendering artefacts
From:       René J.V. Bertin <rjvbertin () gmail ! com>
Date:       2016-06-08 21:16:13
Message-ID: 20160608211613.28421.49551 () mimi ! kde ! org
[Download RAW message or body]

--===============1142516191983152427==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128130/
-----------------------------------------------------------

Review request for KDE Software on Mac OS X and Yichao Yu.

Repository: qtcurve

Description
-------

Qt4 for Mac OS X has certain shortcomings that can cause rendering artefacts when \
compositing is used. In QtCurve this can be avoided which made it the preferred \
widget style for the MacPorts KDE4 ports. The artefact does occur when using rounded \
popup menus. Popup menus ought to have rounded corners in order to follow the native \
style. This works fine under Qt5 but with Qt4 this causes menus to appear empty \
except under the mouse cursor.

Since the Qt4 and Qt5 styles share a single preferences file, I propose a patch for \
qt4/qtcurve.cpp . This makes the code pretend (on OS X) that the "square popup menus" \
attribute is always set, regardless of the actual setting

Diffs
-----

  qt4/style/qtcurve.cpp 059d906 

Diff: https://git.reviewboard.kde.org/r/128130/diff/

Testing
-------

On OS X 10.9 and Linux, both with Qt 4.8.7 and Qt 5.6.0

Thanks,

René J.V. Bertin

--===============1142516191983152427==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/128130/">https://git.reviewboard.kde.org/r/128130/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Software on Mac OS X and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Qt4 for Mac OS X has certain shortcomings that can \
cause rendering artefacts when compositing is used. In QtCurve this can be avoided \
which made it the preferred widget style for the MacPorts KDE4 ports. The artefact \
does occur when using rounded popup menus. Popup menus ought to have rounded corners \
in order to follow the native style. This works fine under Qt5 but with Qt4 this \
causes menus to appear empty except under the mouse cursor.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since \
the Qt4 and Qt5 styles share a single preferences file, I propose a patch for \
qt4/qtcurve.cpp . This makes the code pretend (on OS X) that the "square popup menus" \
attribute is always set, regardless of the actual setting</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9 and Linux, both with Qt 4.8.7 and Qt \
5.6.0</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>qt4/style/qtcurve.cpp <span style="color: grey">(059d906)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/128130/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1142516191983152427==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac

[prev in list] [next in list] [prev in thread] [next in thread] 