'Re: [KDE/Mac] Review Request 127932: [OS X] open documents from Finder (= through LaunchServices) an'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-mac
Subject:    Re: [KDE/Mac] Review Request 127932: [OS X] open documents from Finder (= through LaunchServices) an
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2016-05-29 20:29:47
Message-ID: 20160529202947.8640.19081 () mimi ! kde ! org
[Download RAW message or body]

--===============7110845434420505696==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127932/#review96004
-----------------------------------------------------------

Ship it!

Ship It!

- Aurélien Gâteau

On mai 24, 2016, 5:10 après-midi, René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127932/
> -----------------------------------------------------------
> 
> (Updated mai 24, 2016, 5:10 après-midi)
> 
> 
> Review request for Gwenview and KDE Software on Mac OS X.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This patch takes care of 2 things on OS X:
> - it prevents the application icon (installed via `ecm_add_app_icon`) to be \
> replaced by an empty icon in main \
>                 (`QApplication::setWindowIcon(QIcon::fromTheme(QStringLiteral("gwenview")))`)
>                 
> - it installs an extended `Info.plist` and an event filter that catches \
> `QFileOpenEvent`s so that gwenview can open documents served through \
> LaunchServices, e.g. when using the Finder's "Open With" function. This same code \
> should also work under MS Windows. 
> 
> Diffs
> -----
> 
> app/CMakeLists.txt dcf486f 
> app/main.cpp f9c87c3 
> app/mainwindow.h 6d252f9 
> app/mainwindow.cpp 7b30c4e 
> 
> Diff: https://git.reviewboard.kde.org/r/127932/diff/
> 
> 
> Testing
> -------
> 
> With OS X 10.9.5, Qt 5.6.0 and K5FWs 5.20.0 . It currently doesn't attempt to queue \
> incoming requests in some sort of temporal buffer so that it can open groups of \
> documents. 
> 
> Thanks,
> 
> René J.V. Bertin
> 
> 

--===============7110845434420505696==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/127932/">https://git.reviewboard.kde.org/r/127932/</a>
  </td>
    </tr>
   </table>
   <br />

<p>

Ship it!

</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aurélien Gâteau</p>

<br />
<p>On mai 24th, 2016, 5:10 après-midi CEST, René J.V. Bertin wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview and KDE Software on Mac OS X.</div>
<div>By René J.V. Bertin.</div>

<p style="color: grey;"><i>Updated mai 24, 2016, 5:10 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">This patch takes care of 2 things on \
                OS X:
- it prevents the application icon (installed via <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">ecm_add_app_icon</code>) to be replaced by an empty icon in main (<code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">QApplication::setWindowIcon(QIcon::fromTheme(QStringLiteral("gwenview")))</code>)

- it installs an extended <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Info.plist</code> and an event filter that catches <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">QFileOpenEvent</code>s so that gwenview can open documents \
served through LaunchServices, e.g. when using the Finder's "Open With" function. \
This same code should also work under MS Windows.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">With OS X 10.9.5, Qt 5.6.0 and K5FWs 5.20.0 . It \
currently doesn't attempt to queue incoming requests in some sort of temporal buffer \
so that it can open groups of documents.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>app/CMakeLists.txt <span style="color: grey">(dcf486f)</span></li>

 <li>app/main.cpp <span style="color: grey">(f9c87c3)</span></li>

 <li>app/mainwindow.h <span style="color: grey">(6d252f9)</span></li>

 <li>app/mainwindow.cpp <span style="color: grey">(7b30c4e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/127932/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============7110845434420505696==--

[Attachment #3 (text/plain)]

_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac

[prev in list] [next in list] [prev in thread] [next in thread] 