[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: [KDE/Mac] Review Request 127896: make dbus optional on osx: kauth
From: David Edmundson <david () davidedmundson ! co ! uk>
Date: 2016-05-21 22:45:55
Message-ID: 20160521224555.15344.68388 () mimi ! kde ! org
[Download RAW message or body]
--===============1184931695427601398==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127896/#review95394
-----------------------------------------------------------
src/CMakeLists.txt (line 32)
<https://git.reviewboard.kde.org/r/127896/#comment64677>
In theory - nothing in KAuth should be using DBus outside of the helpers.
(and that autotest that uses the helper)
You should be able to make this change unconditionally - and move finding DBus to \
src/ConfigureChecks cmake
Then we can change those autotests to use the right backend depending on which \
backend get built - which is more semantically correct.
Otherwise we still have a problem that I can manually select the fake backend via \
KAUTH_HELPER_BACKEND_NAME, yet still end up using a test requiring DBus for something \
that isn't being built.
- David Edmundson
On May 20, 2016, 9:13 p.m., Nick Shaforostoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127896/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 9:13 p.m.)
>
>
> Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and \
> Martin Gräßlin.
>
> Repository: kauth
>
>
> Description
> -------
>
> this is the first patch to make kde frameworks build (and then work) without dbus.
>
> this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. \
> as dbus is not a common service in osx world, kde apps on osx should use native \
> means for interprocess communication instead -- this will make them better citizens \
> in osx ecosystem.
>
> Diffs
> -----
>
> CMakeLists.txt 48dc2d9
> autotests/BackendsManager.cpp 59675b3
> autotests/CMakeLists.txt b53d760
> autotests/HelperTest.cpp 8050a06
> src/CMakeLists.txt 1b6930d
> src/ConfigureChecks.cmake d46761a
>
> Diff: https://git.reviewboard.kde.org/r/127896/diff/
>
>
> Testing
> -------
>
> compiles fine on osx, compiles fine on linux, tests on linux still pass.
>
>
> Thanks,
>
> Nick Shaforostoff
>
>
--===============1184931695427601398==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127896/">https://git.reviewboard.kde.org/r/127896/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/127896/diff/1/?file=464634#file464634line35" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">if \
(Qt5DBus_FOUND)</pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
theory - nothing in KAuth should be using DBus outside of the helpers. (and that \
autotest that uses the helper)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">You should be able to \
make this change unconditionally - and move finding DBus to src/ConfigureChecks \
cmake</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Then we can change those autotests to use the right \
backend depending on which backend get built - which is more semantically \
correct.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Otherwise we still have a problem that I can manually \
select the fake backend via KAUTH_HELPER_BACKEND_NAME, yet still end up using a test \
requiring DBus for something that isn't being built.</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On May 20th, 2016, 9:13 p.m. UTC, Nick Shaforostoff wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, \
and Martin Gräßlin.</div> <div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated May 20, 2016, 9:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">this is the first patch to make kde frameworks build \
(and then work) without dbus.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">this will allow \
homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a \
common service in osx world, kde apps on osx should use native means for interprocess \
communication instead -- this will make them better citizens in osx \
ecosystem.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles fine on osx, compiles fine on linux, tests on \
linux still pass.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(48dc2d9)</span></li>
<li>autotests/BackendsManager.cpp <span style="color: grey">(59675b3)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(b53d760)</span></li>
<li>autotests/HelperTest.cpp <span style="color: grey">(8050a06)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(1b6930d)</span></li>
<li>src/ConfigureChecks.cmake <span style="color: grey">(d46761a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127896/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1184931695427601398==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic