[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: [KDE/Mac] Review Request 127972: Always update the Predicate parser from y/l sources
From: Pino Toscano <pino () kde ! org>
Date: 2016-05-20 16:34:34
Message-ID: 20160520163434.21721.62169 () mimi ! kde ! org
[Download RAW message or body]
--===============3511290732150391279==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On May 20, 2016, 8:39 a.m., René J.V. Bertin wrote:
> > Looks good but I'll try to do a test-build during one of my next "lost moments".
> >
> > Is there a minimum required version for either of the parser/generators?
> Is there a minimum required version for either of the parser/generators?
Not that I know of.
- Pino
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127972/#review95644
-----------------------------------------------------------
On May 20, 2016, 6:39 a.m., Pino Toscano wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127972/
> -----------------------------------------------------------
>
> (Updated May 20, 2016, 6:39 a.m.)
>
>
> Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and Lukáš \
> Tinkl.
>
> Repository: solid
>
>
> Description
> -------
>
> Turn Flex and Bison into required build dependencies, and use them to always \
> regenerate at build time the Predicate parser. This ensures that the parser does \
> not rot, and there is no more need to rely on autogenerated sources added \
> statically among the others.
> Second commit: remove old generated files of Predicate parser
>
>
> Diffs
> -----
>
> CMakeLists.txt 763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741
> src/solid/CMakeLists.txt f2b43b27cb47531ed57b2eccafad8e67951b56b9
> src/solid/devices/CMakeLists.txt 9271ae1e36b67b112be54a6ff9c6fb76a8a0a824
> src/solid/devices/predicate_lexer.c 3b5a0b90907baf1cd2631da4de650ec153d0f642
> src/solid/devices/predicate_parser.h 68e25070d498f5a635489af51f4b772c5f374108
> src/solid/devices/predicate_parser.c 6d35ff25f001a43cbfecacc11e7d7591bb4808f9
>
> Diff: https://git.reviewboard.kde.org/r/127972/diff/
>
>
> Testing
> -------
>
> Builds fine with flex 2.6.0 and bison 3.0.4; `make test` passes too.
>
>
> Thanks,
>
> Pino Toscano
>
>
--===============3511290732150391279==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127972/">https://git.reviewboard.kde.org/r/127972/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 20th, 2016, 8:39 a.m. UTC, <b>René J.V. \
Bertin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Looks good but I'll try to do a test-build during one \
of my next "lost moments".</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Is there a minimum required version for \
either of the parser/generators?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Is there a minimum required version for either of the \
parser/generators?</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Not that I know of.</p></pre> <br />
<p>- Pino</p>
<br />
<p>On May 20th, 2016, 6:39 a.m. UTC, Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and Lukáš \
Tinkl.</div> <div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated May 20, 2016, 6:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Turn Flex and Bison into required build dependencies, \
and use them to always regenerate at build time the Predicate parser. This ensures \
that the parser does not rot, and there is no more need to rely on autogenerated \
sources added statically among the others.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Second commit: remove \
old generated files of Predicate parser</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Builds fine with flex 2.6.0 and bison 3.0.4; <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">make test</code> passes too.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741)</span></li>
<li>src/solid/CMakeLists.txt <span style="color: \
grey">(f2b43b27cb47531ed57b2eccafad8e67951b56b9)</span></li>
<li>src/solid/devices/CMakeLists.txt <span style="color: \
grey">(9271ae1e36b67b112be54a6ff9c6fb76a8a0a824)</span></li>
<li>src/solid/devices/predicate_lexer.c <span style="color: \
grey">(3b5a0b90907baf1cd2631da4de650ec153d0f642)</span></li>
<li>src/solid/devices/predicate_parser.h <span style="color: \
grey">(68e25070d498f5a635489af51f4b772c5f374108)</span></li>
<li>src/solid/devices/predicate_parser.c <span style="color: \
grey">(6d35ff25f001a43cbfecacc11e7d7591bb4808f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127972/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3511290732150391279==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic