[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: [KDE/Mac] Review Request 120323: [OSX] shortcut adaptation to platform standards
From: René J.V. Bertin <rjvbertin () gmail ! com>
Date: 2015-12-29 9:39:42
Message-ID: 20151229093942.18086.60914 () mimi ! kde ! org
[Download RAW message or body]
--===============2579947245294030855==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Oct. 6, 2014, 4:01 p.m., Kurt Hindenburg wrote:
> > The Enum has been commited to 4.13 and 4.14 - I'll see about which shortcuts to \
> > change.
>
> René J.V. Bertin wrote:
> Do you happen to know how KDE's shortcut management system works, esp. if it's \
> possible to export a scheme and import it elsewhere? It seems that it should be \
> possible, also to provide multiple schemes with the install (say a legacy scheme \
> and a new, updated scheme), but I've never got that to work (not even on Linux).
Reviving this RR now that I have gotten Konsole 15.12 to build on OS X.
It looks like nothing has changed in the code on this end. I appear not to be using \
any local patches for Konsole4, but yet I get the customary Command-C and Command-V \
for copy/paste, something I have not been able to manage with Konsole5 yet. Evidently \
I cannot remember if made some specific runtime shortcut configurations for Konsole4, \
and have never been able to figure out how these schemes are saved, can be exported \
etc.
I did notice that there is something fishy with the other lowlevel Qt behavioural \
attribute, AA_DontUseNativeMenus. Setting that attribute leads to the regular \
"in-window" menu in Konsole5, but leaves the toplevel menu. It the Ctrl/Meta swap \
attribute has a similarly ambiguous behaviour that would explain a lot ...
- René J.V.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120323/#review67990
-----------------------------------------------------------
On Sept. 22, 2014, 10:02 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120323/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2014, 10:02 p.m.)
>
>
> Review request for KDE Software on Mac OS X and Konsole.
>
>
> Repository: konsole
>
>
> Description
> -------
>
> OS X uses the Command (?, Apple) key as a modifier/opcode for keyboard accelerators \
> aka shortcuts. This is the likely reason why Qt has swapped Qt::CTRL and Qt::META \
> by default on that platform, but Konsole deactivates that feature. As a result, \
> shortcuts are identical to what they are on other platforms, but not in line with \
> what's standard on OS X.
> I introduced a proxy for the standard accelerator opcode, to minimise the amount of \
> conditional code blocks required to adapt Konsole to OS X. There is an added \
> benefit of not using the Control key for shortcuts: `Copy` can be the usual \
> `Command-C` instead of `Ctrl-Shift-C` on other platforms; idem for the `Paste` \
> shortcut. I've adapted the shortcuts of a few other actions to the key combinations \
> OS X uses for those actions.
>
> Diffs
> -----
>
> src/Application.cpp 06f9321
> src/MainWindow.cpp 6e47939
> src/Session.h 9e982df
> src/SessionController.cpp b098d4c
> src/ViewManager.cpp 697ec99
> src/tests/PartManualTest.cpp 07489dd
>
> Diff: https://git.reviewboard.kde.org/r/120323/diff/
>
>
> Testing
> -------
>
> on OS X 10.6.8 with kdelibs 4.14.1 (git/kde4).
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============2579947245294030855==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120323/">https://git.reviewboard.kde.org/r/120323/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On October 6th, 2014, 4:01 p.m. CEST, <b>Kurt \
Hindenburg</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The Enum has been commited to 4.13 and 4.14 - I'll see \
about which shortcuts to change.</p></pre> </blockquote>
<p>On October 6th, 2014, 4:36 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do \
you happen to know how KDE's shortcut management system works, esp. if it's possible \
to export a scheme and import it elsewhere? It seems that it should be possible, also \
to provide multiple schemes with the install (say a legacy scheme and a new, updated \
scheme), but I've never got that to work (not even on Linux).</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Reviving this RR now that I have gotten Konsole 15.12 to build on OS X.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It looks like nothing has changed in the code on this \
end. I appear not to be using any local patches for Konsole4, but yet I get the \
customary Command-C and Command-V for copy/paste, something I have not been able to \
manage with Konsole5 yet. Evidently I cannot remember if made some specific runtime \
shortcut configurations for Konsole4, and have never been able to figure out how \
these schemes are saved, can be exported etc.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did \
notice that there is something fishy with the other lowlevel Qt behavioural \
attribute, AA_DontUseNativeMenus. Setting that attribute leads to the regular \
"in-window" menu in Konsole5, but leaves the toplevel menu. It the Ctrl/Meta swap \
attribute has a similarly ambiguous behaviour that would explain a lot ...</p></pre> \
<br />
<p>- René J.V.</p>
<br />
<p>On September 22nd, 2014, 10:02 p.m. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and Konsole.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Sept. 22, 2014, 10:02 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">OS X uses the Command (?, Apple) key as a \
modifier/opcode for keyboard accelerators aka shortcuts. This is the likely reason \
why Qt has swapped Qt::CTRL and Qt::META by default on that platform, but Konsole \
deactivates that feature. As a result, shortcuts are identical to what they are on \
other platforms, but not in line with what's standard on OS X.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
introduced a proxy for the standard accelerator opcode, to minimise the amount of \
conditional code blocks required to adapt Konsole to OS X. There is an added benefit \
of not using the Control key for shortcuts: <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Copy</code> can be the usual <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Command-C</code> instead of <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Ctrl-Shift-C</code> on other platforms; idem for the <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">Paste</code> shortcut. I've adapted the shortcuts of a few \
other actions to the key combinations OS X uses for t hose actions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">on OS X 10.6.8 with kdelibs 4.14.1 \
(git/kde4).</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Application.cpp <span style="color: grey">(06f9321)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(6e47939)</span></li>
<li>src/Session.h <span style="color: grey">(9e982df)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(b098d4c)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(697ec99)</span></li>
<li>src/tests/PartManualTest.cpp <span style="color: grey">(07489dd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120323/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2579947245294030855==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic