[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: [KDE/Mac] Review Request 125043: expose the WheelMouseZooms global setting through the input ("m
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2015-09-04 16:14:20
Message-ID: 20150904161420.10622.72182 () mimi ! kde ! org
[Download RAW message or body]
--===============0227130483988334011==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Set. 4, 2015, 3:38 p.m., Martin Gräßlin wrote:
> > You are aware that this is a dead repo and that this is a new feature for a \
> > repository that has been feature frozen for years?
> > Given that I think this should not and never be merged. If you want to keep the \
> > repo going for OSX I suggest to create a branch for your patches.
>
> René J.V. Bertin wrote:
> As I wrote in the summary, I don't consider this so much a new feature as a fix to \
> an omission because the parameter is used in kdelibs (and possible elsewhere I \
> don't know about). Besides, this concerns a KCM that I think should have been part \
> of kde-runtime (but that's probably a moot point).
> Also, this is not only about OS X. There are several distribution releases that \
> ship KDE4 as the default desktop officially supported LTS version, and I'd hope \
> they too would be interested in upstream fixes. As such I don't see the point in \
> creating another branch, or in maintaining a freeze on a branch that isn't going to \
> see any more releases A separate repository with only fixes, organised by project \
> and possibly target platform could make sense though.
> Luigi Toscano wrote:
> I disagree: a separate branch makes definitely more sense than a separate \
> repository (which would lead more confusion and divide the code).
> René J.V. Bertin wrote:
> In case it wasn't clear: I meant a separate repository containing only patchfiles. \
> The patch under consideration here is not specific to OS X so wouldn't justify the \
> creation of an OS X branch (I just haven't gotten around to including it in my \
> Kubuntu PPA yet).
> Jeremy Whiting wrote:
> I think what Martin and Luigi are suggesting is a branch maybe called LTS or \
> something for feature improvements since master is frozen and has been for quite a \
> long time.
Exactly, a separate repository with patches does not make sense (git already manages \
patches).
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125043/#review84821
-----------------------------------------------------------
On Set. 4, 2015, 4:22 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125043/
> -----------------------------------------------------------
>
> (Updated Set. 4, 2015, 4:22 p.m.)
>
>
> Review request for KDE Software on Mac OS X, kde-workspace and kdelibs.
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> KDE4 has been providing a setting that (would have) allowed to avoid unwanted text \
> zooming during simulated inertial scrolling (scroll coasting). KDE PIM applications \
> were immune to that issue because certain KDELibs classes use the parameter, which \
> made it all the more annoying that other (e.g. Kate-based) applications weren't. \
> Sadly this setting wasn't published via a GUI.
> This patch adds a checkbox to the input ("mouse") KCM which seemed like the most \
> appropriate place if not only because it also makes sense to provide this KCM on \
> non-X11 platforms like OS X and MS Windows (where settings like "double or single \
> click" are relevant).
> I consider this a fix of an omission bug, but I realise that it could also be \
> considered a new feature, so this RR is also intended to give some public exposure \
> to my patch rather than keeping it to myself.
>
> Diffs
> -----
>
> kcontrol/input/kmousedlg.ui b48a606
> kcontrol/input/mouse.h d926a99
> kcontrol/input/mouse.cpp cebb174
>
> Diff: https://git.reviewboard.kde.org/r/125043/diff/
>
>
> Testing
> -------
>
> For now only on OS X with kdelibs 4.14.11 .
>
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============0227130483988334011==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125043/">https://git.reviewboard.kde.org/r/125043/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On settembre 4th, 2015, 3:38 p.m. CEST, <b>Martin \
Gräßlin</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You are aware that this is a dead repo and that this \
is a new feature for a repository that has been feature frozen for years?</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Given that I think this should not and never be merged. If you want to keep \
the repo going for OSX I suggest to create a branch for your patches.</p></pre> \
</blockquote>
<p>On settembre 4th, 2015, 4:40 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As I \
wrote in the summary, I don't consider this so much a new feature as a fix to an \
omission because the parameter is used in kdelibs (and possible elsewhere I don't \
know about). Besides, this concerns a KCM that I think should have been part of \
kde-runtime (but that's probably a moot point).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, \
this is not only about OS X. There are several distribution releases that ship KDE4 \
as the default desktop officially supported LTS version, and I'd hope they too would \
be interested in upstream fixes. As such I don't see the point in creating another \
branch, or in maintaining a freeze on a branch that isn't going to see any more \
releases A separate repository with only fixes, organised by project and possibly \
target platform could make sense though.</p></pre> </blockquote>
<p>On settembre 4th, 2015, 4:43 p.m. CEST, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
disagree: a separate branch makes definitely more sense than a separate repository \
(which would lead more confusion and divide the code).</p></pre> </blockquote>
<p>On settembre 4th, 2015, 6:04 p.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
case it wasn't clear: I meant a separate repository containing only patchfiles. The \
patch under consideration here is not specific to OS X so wouldn't justify the \
creation of an OS X branch (I just haven't gotten around to including it in my \
Kubuntu PPA yet).</p></pre> </blockquote>
<p>On settembre 4th, 2015, 6:10 p.m. CEST, <b>Jeremy Whiting</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think what Martin and Luigi are suggesting is a branch maybe called LTS or something \
for feature improvements since master is frozen and has been for quite a long \
time.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Exactly, a separate repository with patches does not make sense (git \
already manages patches).</p></pre> <br />
<p>- Luigi</p>
<br />
<p>On settembre 4th, 2015, 4:22 p.m. CEST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X, kde-workspace and kdelibs.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Set. 4, 2015, 4:22 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KDE4 has been providing a setting that (would have) \
allowed to avoid unwanted text zooming during simulated inertial scrolling (scroll \
coasting). KDE PIM applications were immune to that issue because certain KDELibs \
classes use the parameter, which made it all the more annoying that other (e.g. \
Kate-based) applications weren't. Sadly this setting wasn't published via a GUI.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds a checkbox to the input ("mouse") KCM \
which seemed like the most appropriate place if not only because it also makes sense \
to provide this KCM on non-X11 platforms like OS X and MS Windows (where settings \
like "double or single click" are relevant).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I consider this a fix \
of an omission bug, but I realise that it could also be considered a new feature, so \
this RR is also intended to give some public exposure to my patch rather than keeping \
it to myself.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For now only on OS X with kdelibs 4.14.11 .</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcontrol/input/kmousedlg.ui <span style="color: grey">(b48a606)</span></li>
<li>kcontrol/input/mouse.h <span style="color: grey">(d926a99)</span></li>
<li>kcontrol/input/mouse.cpp <span style="color: grey">(cebb174)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125043/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0227130483988334011==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic