[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: [KDE/Mac] Review Request 122115: [OS X] source code adaptations to OS X
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2015-01-18 3:01:44
Message-ID: 20150118030144.19347.65706 () probe ! kde ! org
[Download RAW message or body]
--===============0440951219387029912==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122115/#review74221
-----------------------------------------------------------
Ship it!
Looks safe enough for me. I added a few comments inside that are more food for \
thought than things that need to change.
karbon/ui/KarbonView.cpp
<https://git.reviewboard.kde.org/r/122115/#comment51535>
I think you should also provide a patch for this to the kde frameworks.
libs/db/drivers/sqlite/sqliteconnection.cpp
<https://git.reviewboard.kde.org/r/122115/#comment51536>
But this define is for both plugins and actual libraries, isn't it? Is this \
safe?
dded
- Inge Wallin
On Jan. 17, 2015, 11:17 p.m., René J.V. Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122115/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2015, 11:17 p.m.)
>
>
> Review request for Calligra and KDE Software on Mac OS X.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This patch is a companion to the build system adaptations from RR \
> 122114(https://git.reviewboard.kde.org/r/122114/), and includes a number of \
> adaptations to OS X peculiarities.
> In order of appearance in the patch file:
> - OS X has a so-called `application menu` which has a number of standard `menu \
> items` (actions in Qt speak): About, Preferences and Quit. Qt tries to guess which \
> actions are to be assigned to these menu items, in a 1st come, 1st served fashion \
> and using text-based heuristics on the action text. This works reliably enough for \
> Quit, but not so for the About and Preferences items which both tend to have \
> multiple matches in KDE menus. For this reason it is good practice to `setMenuRole` \
> on the relevant actions when they are created.
> - `typedef void* GLsync`: in order not to impose a required dependency on GLEW.
> - KDE applications commonly use the `.so` extension for shared modules and plugins, \
> and the build system creates them that way.
>
> Diffs
> -----
>
> flow/part/FlowView.cpp 5ce755f
> karbon/ui/KarbonView.cpp db71464
> krita/ui/opengl/kis_opengl_canvas2_p.h 16ba118
> libs/db/drivers/sqlite/sqliteconnection.cpp 23a6eca
> libs/kopageapp/KoPAView.cpp fa0e381
> words/part/KWView.cpp 9f2f230
>
> Diff: https://git.reviewboard.kde.org/r/122115/diff/
>
>
> Testing
> -------
>
> On OS X 10.9.5 with kdelibs 4.14.4 and Qt 4.8.6, on a mid 2011 13" Macbook Pro \
> (2.7Ghz dual-core i7, Intel HD3000 graphics)
>
> Thanks,
>
> René J.V. Bertin
>
>
--===============0440951219387029912==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122115/">https://git.reviewboard.kde.org/r/122115/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
safe enough for me. I added a few comments inside that are more food for thought \
than things that need to change.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122115/diff/1/?file=342472#file342472line1214" \
style="color: black; font-weight: bold; text-decoration: \
underline;">karbon/ui/KarbonView.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KarbonView::initActions()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1214</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c1">// not sure why this isn't done through KStandardAction, but since it \
isn't</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
think you should also provide a patch for this to the kde frameworks.</p></pre> \
</div> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122115/diff/1/?file=342474#file342474line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/db/drivers/sqlite/sqliteconnection.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#define SHARED_LIB_EXTENSION ".so"</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But \
this define is for both plugins and actual libraries, isn't it? Is this \
safe?</p></pre> </div>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">dded</p></pre>
<p>- Inge Wallin</p>
<br />
<p>On January 17th, 2015, 11:17 p.m. CET, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Calligra and KDE Software on Mac OS X.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2015, 11:17 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch is a companion to the build system \
adaptations from RR 122114(https://git.reviewboard.kde.org/r/122114/), and includes a \
number of adaptations to OS X peculiarities.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">In order of appearance \
in the patch file:
- OS X has a so-called <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">application menu</code> which \
has a number of standard <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: inherit;">menu items</code> (actions in \
Qt speak): About, Preferences and Quit. Qt tries to guess which actions are to be \
assigned to these menu items, in a 1st come, 1st served fashion and using text-based \
heuristics on the action text. This works reliably enough for Quit, but not so for \
the About and Preferences items which both tend to have multiple matches in KDE \
menus. For this reason it is good practice to <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">setMenuRole</code> on the relevant actions when they are \
created.
- <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">typedef void* GLsync</code>: in order not to \
impose a required dependency on GLEW.
- KDE applications commonly use the <code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.so</code> \
extension for shared modules and plugins, and the build system creates them that \
way.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">On OS X 10.9.5 with kdelibs 4.14.4 and Qt 4.8.6, on a \
mid 2011 13" Macbook Pro (2.7Ghz dual-core i7, Intel HD3000 graphics)</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/FlowView.cpp <span style="color: grey">(5ce755f)</span></li>
<li>karbon/ui/KarbonView.cpp <span style="color: grey">(db71464)</span></li>
<li>krita/ui/opengl/kis_opengl_canvas2_p.h <span style="color: \
grey">(16ba118)</span></li>
<li>libs/db/drivers/sqlite/sqliteconnection.cpp <span style="color: \
grey">(23a6eca)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(fa0e381)</span></li>
<li>words/part/KWView.cpp <span style="color: grey">(9f2f230)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122115/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0440951219387029912==--
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic