[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-mac
Subject: Re: [KDE/Mac] Review Request 119533: Make ktimetracker build on OS X,
From: "Allen Winter" <winter () kde ! org>
Date: 2014-07-31 12:42:15
Message-ID: 20140731124215.3288.19024 () probe ! kde ! org
[Download RAW message or body]
--===============2660232829559515396==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On July 31, 2014, 12:10 p.m., Allen Winter wrote:
> > CMakeLists.txt, line 310
> > <https://git.reviewboard.kde.org/r/119533/diff/1/?file=294203#file294203line310>
> >
> > remove the conditional now
If you don't have commit access, please let us know so someone else can commit for you.
- Allen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119533/#review63558
-----------------------------------------------------------
On July 29, 2014, 11:22 a.m., RJVB Bertin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119533/
> -----------------------------------------------------------
>
> (Updated July 29, 2014, 11:22 a.m.)
>
>
> Review request for KDE Software on Mac OS X and KDEPIM.
>
>
> Repository: kdepim
>
>
> Description
> -------
>
> Signed-off-by: RJVB <rjvbertin@gmail.com>
>
>
> Diffs
> -----
>
> CMakeLists.txt d12b90a3cf294f8a0a236e2021b251b00e85aec3
> ktimetracker/CMakeLists.txt bf7b0ef41d851055359dc2cdcb2d2d3cbce25a6d
> ktimetracker/idletimedetector.h 524f739e89a77d1dbd732af8f258b3276e994eba
> ktimetracker/idletimedetector.cpp 250dda55582f53cfc44242582dee7e07062f5358
> ktimetracker/ktimetrackerutility.cpp efeba3abdc94a3725f0e0d6a9b663959a06dcc1f
> ktimetracker/mainwindow.cpp 56d4c286213507490b31fb131f1097a4c00b7abe
>
> Diff: https://git.reviewboard.kde.org/r/119533/diff/
>
>
> Testing
> -------
>
> Testing was done under KDE and KDEPIM 4.12.5, MacPorts. The patches from that version applied without \
> issues on the code in git, with 2 exceptions that I could re-apply manually easily.
> With these patches, ktimetracker builds and launches under OS X (•) and loads existing \
> ktimetracker.ics files correctly. The idle time detection feature appears to work as far as I'm able to \
> tell (I don't use it under Linux).
> What remains to be done is to double-check the timing precision: I've had an impression that timing may \
> be too fast but haven't been able to prove timing isn't correct.
> The history output to clipboard feature does ignore the date range and "output only the selection" \
> options; removing entries originating from Linux we have
> "test" 0.00 0.00
> "test->test 1" 0.07 0.03
> "test->test 2" 0.00 0.06
> "test->test 3" 0.00 0.03
> "test->test 4" 0.00 0.03
>
> and the timing output (which does honour the "output only the selection" option):
>
> Totaux des tâches
> 20140729 13:09
>
> Durée Tâche
> ----------------------------------------------
> 0:12 test
> 0:05 test 1
> 0:03 test 2
> 0:02 test 3
> 0:02 test 4
> ----------------------------------------------
> 0:12 Total
>
>
> •) this supposes libical is installed and built following https://trac.macports.org/ticket/44469, \
> i.e. using cmake instead and including a patch from Ubuntu.
>
> Thanks,
>
> RJVB Bertin
>
>
--===============2660232829559515396==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119533/">https://git.reviewboard.kde.org/r/119533/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 31st, 2014, 12:10 p.m. UTC, <b>Allen Winter</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: \
collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: \
4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119533/diff/1/?file=294203#file294203line310" style="color: \
black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">310</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: \
140%; margin: 0; "> <span class="nb">if</span><span class="p">(</span><span \
class="s">Q_WS_X11</span><span class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: \
1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">310</font></th> <td \
bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="c"><span class="hl">#</span>if(Q_WS_X11)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">remove the conditional now</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">If you don't have commit access, please let us know so \
someone else can commit for you.</p></pre> <br />
<p>- Allen</p>
<br />
<p>On July 29th, 2014, 11:22 a.m. UTC, RJVB Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Software on Mac OS X and KDEPIM.</div>
<div>By RJVB Bertin.</div>
<p style="color: grey;"><i>Updated July 29, 2014, 11:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdepim
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Signed-off-by: RJVB \
<rjvbertin@gmail.com></p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Testing was done under KDE and KDEPIM \
4.12.5, MacPorts. The patches from that version applied without issues on the code in git, with 2 \
exceptions that I could re-apply manually easily.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">With these patches, ktimetracker builds and \
launches under OS X (•) and loads existing ktimetracker.ics files correctly. The idle time detection \
feature appears to work as far as I'm able to tell (I don't use it under Linux).</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What remains to be done \
is to double-check the timing precision: I've had an impression that timing may be too fast but haven't \
been able to prove timing isn't correct.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The history output to clipboard feature does ignore the \
date range and "output only the selection" options; removing entries originating from Linux we have</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">"test" \
0.00 0.00<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;" /> "test->test 1" 0.07 0.03<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> "test->test 2" 0.00 0.06<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> "test->test 3" 0.00 \
0.03<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> \
"test->test 4" 0.00 0.03</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">and the timing output (which does honour the "output only the selection" \
option):</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Totaux des tâches<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: normal;" /> 20140729 13:09</p>
<h2 style="font-size: 100%;text-rendering: inherit;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">Durée Tâche</h2> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">0:12 test<br style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;" /> 0:05 test 1<br style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;" /> 0:03 test 2<br style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 0:02 test 3<br \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" /> 0:02 \
test 4</p> <hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid \
#ddd;line-height: inherit;" /> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">0:12 Total</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">•) this supposes libical is installed and built following \
https://trac.macports.org/ticket/44469, i.e. using cmake instead and including a patch from \
Ubuntu.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(d12b90a3cf294f8a0a236e2021b251b00e85aec3)</span></li>
<li>ktimetracker/CMakeLists.txt <span style="color: \
grey">(bf7b0ef41d851055359dc2cdcb2d2d3cbce25a6d)</span></li>
<li>ktimetracker/idletimedetector.h <span style="color: \
grey">(524f739e89a77d1dbd732af8f258b3276e994eba)</span></li>
<li>ktimetracker/idletimedetector.cpp <span style="color: \
grey">(250dda55582f53cfc44242582dee7e07062f5358)</span></li>
<li>ktimetracker/ktimetrackerutility.cpp <span style="color: \
grey">(efeba3abdc94a3725f0e0d6a9b663959a06dcc1f)</span></li>
<li>ktimetracker/mainwindow.cpp <span style="color: \
grey">(56d4c286213507490b31fb131f1097a4c00b7abe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119533/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2660232829559515396==--
_______________________________________________
kde-mac@kde.org
List Information: https://mail.kde.org/mailman/listinfo/kde-mac
KDE/Mac Information: http://community.kde.org/Mac
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic