[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-linux
Subject:    Re: [kde-linux] kde 3.3.1 can't be compiled here
From:       James Richard Tyrer <tyrerj () acm ! org>
Date:       2004-10-30 21:47:54
Message-ID: 41840C0A.20200 () acm ! org
[Download RAW message or body]

Christian H. Kuhn wrote:
> & Jim Philips <jimmyc@speedfactory.net> [2004-10-30 17:16]:
> 
>>http://lists.kde.org/?l=kde-devel&m=108947887823347&w=2
> 
> 
> It works. thx a lot.

The official fix is slightly simpler:

--- kdemultimedia/mpeglib/lib/input/cdromAccess_Linux.cpp	2004/04/19 \
01:12:55	1.7
+++ kdemultimedia/mpeglib/lib/input/cdromAccess_Linux.cpp	2004/09/08 \
14:41:44	1.8
@@ -10,12 +10,12 @@

   */

+#include <linux/types.h>
+#include <linux/cdrom.h>
+#include <sys/ioctl.h>

  #include "cdromToc.h"
  #include "cdromRawAccess.h"
-#include <asm/types.h>
-#include <linux/cdrom.h>
-#include <sys/ioctl.h>

  #include <iostream>

So there was an error in the code that is obvious not that someone else fixed 
it. :-)

But there is some question if this will work in all cases:

	http://bugs.kde.org/show_bug.cgi?id=86188

There are bugs in some versions of the Linux headers.

So additional changes were made on HEAD.

--- kdemultimedia/mpeglib/lib/input/cdromAccess_Linux.cpp  #1.8:1.9
   at  at  -11,6 +11,13  at  at
    */

  +#ifdef __STRICT_ANSI__
  +#undef __STRICT_ANSI__
  +#define _ANSI_WAS_HERE_
  +#endif
   #include <linux/types.h>
   #include <linux/cdrom.h>
  +#ifdef _ANSI_WAS_HERE_
  +#define __STRICT_ANSI__
  +#endif
   #include <sys/ioctl.h>

Still don't know exactly why it worked for me but not for you, but I suspect 
that the problem in the Linux headers has been fixed with version >= 2.4.26

The other patch (that you used) should work fine on Linux but may not work on 
other systems.

--
JRT
___________________________________________________
This message is from the kde-linux mailing list.
Account management:  https://mail.kde.org/mailman/listinfo/kde-linux.
Archives: http://lists.kde.org/.
More info: http://www.kde.org/faq.html.
[prev in list] [next in list] [prev in thread] [next in thread]