[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-licensing
Subject:    Re: Messages.sh and license checker
From:       David Faure <faure () kde ! org>
Date:       2011-02-10 12:01:28
Message-ID: 201102101301.28797.faure () kde ! org
[Download RAW message or body]

On Monday 07 February 2011, Ben Cooksley wrote:
> On Mon, Feb 7, 2011 at 9:30 PM, David Faure <faure@kde.org> wrote:
> >> A  +3    -0    konq-plugins/shellcmdplugin/Messages.sh         [License:
> > UNKNOWN]  *
> > 
> >> The files marked with a * at the end have a non valid license. Please 
read:
> > http://techbase.kde.org/Policies/Licensing_Policy and use the headers
> > which are listed at that page.
> > 
> > Do we really need a license in all these trivial Messages.sh files?
> 
> I don't think we do, this may be a git hook regression, although I
> don't see how, as the code is the Python equivalent of the Perl code.
> 
> Was the following line originally meant to indicate 128 lines vs. 128
> characters? (Perl code extracted from svn hooks follows)
>    if ( !$license && length($text) < 128 ) {

No, there are characters.
But even then, it shouldn't match on a 95 chars long Messages.sh :-)

-- 
David Faure, faure@kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).
_______________________________________________
Kde-licensing mailing list
Kde-licensing@kde.org
https://mail.kde.org/mailman/listinfo/kde-licensing
[prev in list] [next in list] [prev in thread] [next in thread]