[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-krn-devel
Subject:    A patch
From:       Magnus Reftel <d96reftl () dtek ! chalmers ! se>
Date:       1997-07-20 22:14:08
[Download RAW message or body]


Hi,

I'm leaving for Norway for about one week, so I'm attaching the changes
I've made, so that anyone who wants to can work on it while I'm away.
The attached file contains a gziped tar file with the new files (I don't
know how to make diff include newly created files, and I couldn't find it
in the man page), and a patch against krn-jul-8.
The new code might need some explaining, since the design isn't as clear
as one could wish =). To allow composing, an instance of PostDialog should
be created and shown, and then it handles the rest by it self. The first
thing the user should do is to click on the Add button, and choose a
message type (only text/plain is supported, and the editor must be set in
the config, like
---
[Editors]
text/plain=emacs %s
---
(%s is expanded to a file name). When the editing is done, the user can
either add another part, change the parts properties (the PartProps
dialog, which currently does nothing), or press "Post now" or "Cancel".
"Post now" tries to make a DwMessage of the parts, fails and pops up a
message box that tells the user that posting does not work yet =(.
One of the things that are most urgently missing is a notion of whether a
part has been created by an editor or read from a file. This could be done
by adding a bool variable to the messagepart struct in PostDialog, which
is set in NewMsgDlg, and checked in PostDialog::cancel().
Oh. The dialog should not be modal, and it should not crash krn when the
groupdlg window is closed. It does both. =(
The PostDialog::postNow() function is completely broken. The fields are
not correct, and some fields are missing, the body creation doesn't work,
and leaks memory. The only good thing about it is that it doesn't segfault
;-)
(this probably was completely unreadable, but I'm in a bit of hurry now,
so it'll have to do =( )

Regards
Magnus


["patch970720.tar.gz" (APPLICATION/octet-stream)]

[prev in list] [next in list] [prev in thread] [next in thread]