--000000000000f82bab060f271e6f
Content-Type: text/plain; charset="UTF-8"

Hi!

I am debugging an issue where changing a layer within a python script does
not affect the activeNode() until the script is finished executing
<https://krita-artists.org/t/active-layer-not-updated-in-plugin/81240>.

Here's what I found:
Within KisNodeManager::Private::activateNodeImpl, there is code that gets a
shape for the node. In the script, this shape ends up being Null, so the
function fails this assert
<https://github.com/KDE/krita/blob/c237d74b5765896e19e481f47e082bbb6cc9816d/libs/ui/kis_node_manager.cpp#L165>
and never gets to "imageView->setCurrentNode
<https://github.com/KDE/krita/blob/c237d74b5765896e19e481f47e082bbb6cc9816d/libs/ui/kis_node_manager.cpp#L177>
".

I've placed a breakpoint in KisNodeDummiesGraph::addNode
<https://github.com/KDE/krita/blob/c237d74b5765896e19e481f47e082bbb6cc9816d/libs/ui/flake/kis_node_dummies_graph.cpp#L116>
and
found that it gets called when copying a layer manually, but not when it's
done in the script.

Chasing this upstream, I found that the KisNodeDummiesGraph::addNode is
called in response to a QEvent within KisSynchronizedConnectionBase::event
but now I'm getting a little lost.

Any pointers on how I could continue chasing this down?
I don't understand what the "Shape" is and at which point in the flow it is
supposed to be added for a new layer.

--000000000000f82bab060f271e6f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi!<div><br></div><div>I am debugging an issue where <a hr=
ef=3D"https://krita-artists.org/t/active-layer-not-updated-in-plugin/81240"=
>changing a layer within a python script does not affect the activeNode() u=
ntil the script is finished executing</a>.</div><div><br></div><div>Here&#3=
9;s what I found:</div><div>Within=C2=A0KisNodeManager::Private::activateNo=
deImpl, there is code that gets a shape for the node. In the script, this s=
hape ends up being Null, so the function fails <a href=3D"https://github.co=
m/KDE/krita/blob/c237d74b5765896e19e481f47e082bbb6cc9816d/libs/ui/kis_node_=
manager.cpp#L165">this assert</a> and never gets=C2=A0to &quot;<a href=3D"h=
ttps://github.com/KDE/krita/blob/c237d74b5765896e19e481f47e082bbb6cc9816d/l=
ibs/ui/kis_node_manager.cpp#L177">imageView-&gt;setCurrentNode</a>&quot;.</=
div><div><br></div><div>I&#39;ve placed a breakpoint in=C2=A0<a href=3D"htt=
ps://github.com/KDE/krita/blob/c237d74b5765896e19e481f47e082bbb6cc9816d/lib=
s/ui/flake/kis_node_dummies_graph.cpp#L116">KisNodeDummiesGraph::addNode</a=
>=C2=A0and found that it gets=C2=A0called when copying a layer manually, bu=
t not when it&#39;s done in the script.<br></div><div><br></div><div>Chasin=
g this upstream, I found that the KisNodeDummiesGraph::addNode is called in=
 response to a QEvent within KisSynchronizedConnectionBase::event but now I=
&#39;m getting a little lost.</div><div><br></div><div>Any pointers on how =
I could continue chasing this down?</div><div>I don&#39;t understand what t=
he &quot;Shape&quot; is and at which point in the flow it is supposed to be=
 added for a new layer.</div></div>

--000000000000f82bab060f271e6f--