From kde-kimageshop  Wed Oct 07 12:21:09 2020
From: Boudewijn Rempt <null () kde ! org>
Date: Wed, 07 Oct 2020 12:21:09 +0000
To: kde-kimageshop
Subject: [graphics/krita/krita/4.3] plugins/generators/simplexnoise: Fix resource leak
Message-Id: <20201007122109.3BF961241C4D () leptone ! kde ! org>
X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=160207328519057

Git commit 51c94f89262b95a25599209e6486f396ebb82c65 by Boudewijn Rempt.
Committed on 07/10/2020 at 12:21.
Pushed by rempt into branch 'krita/4.3'.

Fix resource leak

This is why I do not want auto to be used in Krita's code:

auto bla =3D createSomething();

doesn't warn that you need to delete bla as much as

Bla *bla =3D createSomething();

because it's invisible that bla is a pointer.

The alternative is that we use smart pointers _everywhere_, which
isn't feasible...

CCMAIL:kimageshop@kde.org
CID:305464
(cherry picked from commit befdf9b4d74389c767cf558c183e9f82a30c0c58)

M  +2    -2    plugins/generators/simplexnoise/simplexnoisegenerator.cpp

https://invent.kde.org/graphics/krita/commit/51c94f89262b95a25599209e6486f3=
96ebb82c65

diff --git a/plugins/generators/simplexnoise/simplexnoisegenerator.cpp b/pl=
ugins/generators/simplexnoise/simplexnoisegenerator.cpp
index bf97c34a7c..0562c7f61a 100644
--- a/plugins/generators/simplexnoise/simplexnoisegenerator.cpp
+++ b/plugins/generators/simplexnoise/simplexnoisegenerator.cpp
@@ -65,7 +65,7 @@ void KisSimplexNoiseGenerator::generate(KisProcessingInfo=
rmation dst, const QSiz
 =

     const KoColorSpace *cs =3D device->colorSpace();
     const KoColorSpace *src =3D KoColorSpaceRegistry::instance()->colorSpa=
ce(GrayAColorModelID.id(), Float32BitsColorDepthID.id(), "Gray-D50-elle-V2-=
srgbtrc.icc");
-    auto conv =3D KoColorSpaceRegistry::instance()->createColorConverter(s=
rc, cs, KoColorConversionTransformation::internalRenderingIntent(), KoColor=
ConversionTransformation::internalConversionFlags());
+    KoColorConversionTransformation *conv =3D KoColorSpaceRegistry::instan=
ce()->createColorConverter(src, cs, KoColorConversionTransformation::intern=
alRenderingIntent(), KoColorConversionTransformation::internalConversionFla=
gs());
 =

     KisSequentialIteratorProgress it(device, bounds, progressUpdater);
 =

@@ -117,7 +117,7 @@ void KisSimplexNoiseGenerator::generate(KisProcessingIn=
formation dst, const QSiz
             conv->transform(c.data(), it.rawData(), 1);
         }
     }
-
+    delete conv;
     open_simplex_noise_free(noise_context);
 }
=20