From kde-kimageshop Tue Jul 28 10:55:28 2020 From: scan-admin () coverity ! com Date: Tue, 28 Jul 2020 10:55:28 +0000 To: kde-kimageshop Subject: New Defects reported by Coverity Scan for krita Message-Id: <5f20041fb7f87_c22002ab6ec760f7074ba () prd-scan-dashboard-0 ! mail> X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=159815658926964 Hi, Please find the latest report on new defect(s) introduced to krita found with Coverity Scan. 6 new defect(s) introduced to krita found with Coverity Scan. 45 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan. New defect(s) Reported-by: Coverity Scan Showing 6 of 6 defect(s) ** CID 305467: Low impact quality (MISSING_MOVE_ASSIGNMENT) /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 104 in () ________________________________________________________________________________________________________ *** CID 305467: Low impact quality (MISSING_MOVE_ASSIGNMENT) /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 104 in () 98 } 99 return result; 100 } 101 102 103 template >>> CID 305467: Low impact quality (MISSING_MOVE_ASSIGNMENT) >>> Class "KisWeakSharedPtr" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster. 104 class KisWeakSharedPtr; 105 template 106 class KisSharedPtr; 107 template 108 class KisPinnedSharedPtr; 109 ** CID 305466: (MISSING_MOVE_ASSIGNMENT) /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () ________________________________________________________________________________________________________ *** CID 305466: (MISSING_MOVE_ASSIGNMENT) /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () 100 } 101 102 103 template 104 class KisWeakSharedPtr; 105 template >>> CID 305466: (MISSING_MOVE_ASSIGNMENT) >>> Class "KisSharedPtr" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster. 106 class KisSharedPtr; 107 template 108 class KisPinnedSharedPtr; 109 110 /** 111 * \fn removeSharedPointer /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () 100 } 101 102 103 template 104 class KisWeakSharedPtr; 105 template >>> CID 305466: (MISSING_MOVE_ASSIGNMENT) >>> Class "KisSharedPtr" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster. 106 class KisSharedPtr; 107 template 108 class KisPinnedSharedPtr; 109 110 /** 111 * \fn removeSharedPointer /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () 100 } 101 102 103 template 104 class KisWeakSharedPtr; 105 template >>> CID 305466: (MISSING_MOVE_ASSIGNMENT) >>> Class "KisSharedPtr" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster. 106 class KisSharedPtr; 107 template 108 class KisPinnedSharedPtr; 109 110 /** 111 * \fn removeSharedPointer /home/boud/dev/krita/libs/global/kis_pointer_utils.h: 106 in () 100 } 101 102 103 template 104 class KisWeakSharedPtr; 105 template >>> CID 305466: (MISSING_MOVE_ASSIGNMENT) >>> Class "KisSharedPtr" may benefit from adding a move assignment operator. See other events which show the copy assignment operator being applied to rvalue(s), where a move assignment may be faster. 106 class KisSharedPtr; 107 template 108 class KisPinnedSharedPtr; 109 110 /** 111 * \fn removeSharedPointer ** CID 305465: Uninitialized members (UNINIT_CTOR) /home/boud/dev/krita/plugins/filters/halftone/KisHalftoneConfigWidget.cpp: 85 in KisHalftoneConfigWidget::KisHalftoneConfigWidget(QWidget *, KisSharedPtr)() ________________________________________________________________________________________________________ *** CID 305465: Uninitialized members (UNINIT_CTOR) /home/boud/dev/krita/plugins/filters/halftone/KisHalftoneConfigWidget.cpp: 85 in KisHalftoneConfigWidget::KisHalftoneConfigWidget(QWidget *, KisSharedPtr)() 79 w->hide(); 80 m_channelWidgets.append(w); 81 connect(w, SIGNAL(signal_configurationUpdated()), this, SIGNAL(sigConfigurationUpdated())); 82 } 83 84 connect(m_ui.comboBoxMode, SIGNAL(currentIndexChanged(int)), this, SLOT(slot_comboBoxMode_currentIndexChanged(int))); >>> CID 305465: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_intensityWidget" is not initialized in this constructor nor in any functions that it calls. 85 } 86 87 KisHalftoneConfigWidget::~KisHalftoneConfigWidget() 88 {} 89 90 void KisHalftoneConfigWidget::setConfiguration(const KisPropertiesConfigurationSP config) ** CID 305464: Resource leaks (RESOURCE_LEAK) /home/boud/dev/krita/plugins/generators/simplexnoise/simplexnoisegenerator.cpp: 122 in KisSimplexNoiseGenerator::generate(KisProcessingInformation, const QSize &, KisPinnedSharedPtr, KoUpdater *) const() ________________________________________________________________________________________________________ *** CID 305464: Resource leaks (RESOURCE_LEAK) /home/boud/dev/krita/plugins/generators/simplexnoise/simplexnoisegenerator.cpp: 122 in KisSimplexNoiseGenerator::generate(KisProcessingInformation, const QSize &, KisPinnedSharedPtr, KoUpdater *) const() 116 117 conv->transform(c.data(), it.rawData(), 1); 118 } 119 } 120 121 open_simplex_noise_free(noise_context); >>> CID 305464: Resource leaks (RESOURCE_LEAK) >>> Variable "conv" going out of scope leaks the storage it points to. 122 } 123 124 KisFilterConfigurationSP KisSimplexNoiseGenerator::defaultConfiguration(KisResourcesInterfaceSP resourcesInterface) const 125 { 126 KisFilterConfigurationSP config = factoryConfiguration(resourcesInterface); 127 config->setProperty("looping", false); ** CID 305463: Uninitialized members (UNINIT_CTOR) /home/boud/dev/krita/libs/ui/widgets/kis_gradient_chooser.cc: 76 in KisCustomGradientDialog::KisCustomGradientDialog(QSharedPointer, QWidget *, const char *, QSharedPointer)() ________________________________________________________________________________________________________ *** CID 305463: Uninitialized members (UNINIT_CTOR) /home/boud/dev/krita/libs/ui/widgets/kis_gradient_chooser.cc: 76 in KisCustomGradientDialog::KisCustomGradientDialog(QSharedPointer, QWidget *, const char *, QSharedPointer)() 70 if (segmentedGradient) { 71 m_page = new KisAutogradientEditor(segmentedGradient, this, "autogradient", i18n("Custom Segmented Gradient"), canvasResourcesInterface); 72 } 73 } 74 setCaption(m_page->windowTitle()); 75 setMainWidget(m_page); >>> CID 305463: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "m_page" is not initialized in this constructor nor in any functions that it calls. 76 } 77 78 KisGradientChooser::KisGradientChooser(QWidget *parent, const char *name) 79 : QFrame(parent) 80 { 81 setObjectName(name); ** CID 36099: Uninitialized members (UNINIT_CTOR) /home/boud/dev/krita/libs/brush/kis_brush.cpp: 123 in KisBrush::Private::Private()() ________________________________________________________________________________________________________ *** CID 36099: Uninitialized members (UNINIT_CTOR) /home/boud/dev/krita/libs/brush/kis_brush.cpp: 123 in KisBrush::Private::Private()() 117 , scale(1.0) 118 , gradient(0) 119 , autoSpacingActive(false) 120 , autoSpacingCoeff(1.0) 121 , threadingAllowed(true) 122 { >>> CID 36099: Uninitialized members (UNINIT_CTOR) >>> Non-static class member "preserveLightness" is not initialized in this constructor nor in any functions that it calls. 123 } 124 125 Private(const Private &rhs) 126 : brushType(rhs.brushType), 127 brushApplication(rhs.brushApplication), 128 width(rhs.width), ________________________________________________________________________________________________________ To view the defects in Coverity Scan visit, https://u15810271.ct.sendgrid.net/ls/click?upn=HRESupC-2F2Czv4BOaCWWCy7my0P0qcxCbhZ31OYv50yoiVvSSc0Ywjss83d7yOEUgcCB0VGS755ZaA-2FhoVtwbuw-3D-3DAf6J_9IaX5f-2FHpKL9E6YDsrt7GXrayr4Tk6CKCUhJvkNHrt4yku0D5-2FW9Qu41DPxr6Q46Ci5Sp6IZKJlbTzQIWRoIr5x3qbgEjaOB42rWFB7WYn0-2FKewLdyId6rhgfODzRECQAFomET4deFQwJw6Q8jaQL4Q8MT-2BASeqkxxPr7bWdgNcnHRhNqlSKX3BOLqU1yjQigmY2s5YYmpq6sBfv31ebrcwxAkk7-2FT-2FvekK2d-2BjXFEc-3D