[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-kimageshop
Subject: Re: [graphics/krita] 3rdparty/ext_seexpr: Update SeExpr version
From: Dmitry Kazakov <dimula73 () gmail ! com>
Date: 2020-07-30 18:08:05
Message-ID: CAEkBSfXKnmCbM9cFBHWK9JMd3BrRbG5Y4NzHrjNAUzt-d3rpEg () mail ! gmail ! com
[Download RAW message or body]
Hi, Amyspark!
I've kicked off all five dependency builds!
https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Dependency_Build/
https://binary-factory.kde.org/job/Krita_Android_armeabi-v7a_Dependency_Build/
https://binary-factory.kde.org/job/Krita_Android_x86_Dependency_Build/
https://binary-factory.kde.org/job/Krita_Nightly_MacOS_Dependency_Build/
https://binary-factory.kde.org/job/Krita_Nightly_Windows_Dependency_Build/
On Thu, Jul 30, 2020 at 5:03 AM L. E. Segovia <null@kde.org> wrote:
> Git commit 5161f0fb363c7508f3cfb1955ba9b981185bbc06 by L. E. Segovia.
> Committed on 30/07/2020 at 02:01.
> Pushed by lsegovia into branch 'master'.
>
> Update SeExpr version
>
> Before this commit, Krita would crash when creating vector variables.
>
> When initializing vector variables' widgets with a specified range,
> or attempting to change their value, SeExpr would try to access an
> uninitialized member. The check for null does not work because it was
> never initialized in the first place.
>
> Additionally, I fixed this widget so that it would correctly allow
> vectors with explicit [0, 1] range to be previewed as color variables.
>
> (cherry picked from commit c0495fb7bd6b06157b3c685eb98498e644e181d1)
>
> CCMAIL: kimageshop@kde.org
>
> M +1 -1 3rdparty/ext_seexpr/CMakeLists.txt
>
>
> https://invent.kde.org/graphics/krita/commit/5161f0fb363c7508f3cfb1955ba9b981185bbc06
>
> diff --git a/3rdparty/ext_seexpr/CMakeLists.txt
> b/3rdparty/ext_seexpr/CMakeLists.txt
> index a6e4dd0f7d..5294086edc 100644
> --- a/3rdparty/ext_seexpr/CMakeLists.txt
> +++ b/3rdparty/ext_seexpr/CMakeLists.txt
> @@ -2,7 +2,7 @@ SET(PREFIX_ext_seexpr "${EXTPREFIX}" )
> ExternalProject_Add(
> ext_seexpr
> GIT_REPOSITORY https://invent.kde.org/lsegovia/SeExpr.git
> - GIT_TAG 9c9442c965346325ec7d67c76e139707aa9d3d43
> + GIT_TAG 74737606c01c8a591659c1561b07b695c70f6997
>
> CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${PREFIX_ext_seexpr}
> -DCMAKE_BUILD_TYPE=${GLOBAL_BUILD_TYPE} -DFLAVOR=${GLOBAL_BUILD_TYPE}
> ${GLOBAL_PROFILE} -DBOOST_INCLUDE_DIR=${PREFIX_ext_seexpr}/include
> -DBOOST_ROOT=${PREFIX_ext_seexpr} -DBOOST_LIB_DIR=${PREFIX_ext_seexpr}/lib
> -DENABLE_LLVM_BACKEND=OFF -DENABLE_SSE4=OFF -DBUILD_DOC=OFF
> -DBUILD_TESTS=OFF -DBUILD_UTILS=OFF -DUSE_PYTHON=OFF
>
>
--
Dmitry Kazakov
[Attachment #3 (text/html)]
<div dir="ltr"><div>Hi, Amyspark!</div><div><br></div><div>I've kicked off all \
five dependency builds!</div><div><br></div><div><a \
href="https://binary-factory.kde.org/job/Krita_Nightly_Appimage_Dependency_Build/">htt \
ps://binary-factory.kde.org/job/Krita_Nightly_Appimage_Dependency_Build/</a></div><div><a \
href="https://binary-factory.kde.org/job/Krita_Android_armeabi-v7a_Dependency_Build/"> \
https://binary-factory.kde.org/job/Krita_Android_armeabi-v7a_Dependency_Build/</a></div><div><a \
href="https://binary-factory.kde.org/job/Krita_Android_x86_Dependency_Build/">https://binary-factory.kde.org/job/Krita_Android_x86_Dependency_Build/</a></div><div><a \
href="https://binary-factory.kde.org/job/Krita_Nightly_MacOS_Dependency_Build/">https: \
//binary-factory.kde.org/job/Krita_Nightly_MacOS_Dependency_Build/</a></div><div><a \
href="https://binary-factory.kde.org/job/Krita_Nightly_Windows_Dependency_Build/">http \
s://binary-factory.kde.org/job/Krita_Nightly_Windows_Dependency_Build/</a></div><div><br></div></div><br><div \
class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Jul 30, 2020 at 5:03 AM \
L. E. Segovia <<a href="mailto:null@kde.org">null@kde.org</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Git commit \
5161f0fb363c7508f3cfb1955ba9b981185bbc06 by L. E. Segovia.<br> Committed on \
30/07/2020 at 02:01.<br> Pushed by lsegovia into branch 'master'.<br>
<br>
Update SeExpr version<br>
<br>
Before this commit, Krita would crash when creating vector variables.<br>
<br>
When initializing vector variables' widgets with a specified range,<br>
or attempting to change their value, SeExpr would try to access an<br>
uninitialized member. The check for null does not work because it was<br>
never initialized in the first place.<br>
<br>
Additionally, I fixed this widget so that it would correctly allow<br>
vectors with explicit [0, 1] range to be previewed as color variables.<br>
<br>
(cherry picked from commit c0495fb7bd6b06157b3c685eb98498e644e181d1)<br>
<br>
CCMAIL: <a href="mailto:kimageshop@kde.org" \
target="_blank">kimageshop@kde.org</a><br> <br>
M +1 -1 3rdparty/ext_seexpr/CMakeLists.txt<br>
<br>
<a href="https://invent.kde.org/graphics/krita/commit/5161f0fb363c7508f3cfb1955ba9b981185bbc06" \
rel="noreferrer" target="_blank">https://invent.kde.org/graphics/krita/commit/5161f0fb363c7508f3cfb1955ba9b981185bbc06</a><br>
<br>
diff --git a/3rdparty/ext_seexpr/CMakeLists.txt \
b/3rdparty/ext_seexpr/CMakeLists.txt<br> index a6e4dd0f7d..5294086edc 100644<br>
--- a/3rdparty/ext_seexpr/CMakeLists.txt<br>
+++ b/3rdparty/ext_seexpr/CMakeLists.txt<br>
@@ -2,7 +2,7 @@ SET(PREFIX_ext_seexpr "${EXTPREFIX}" )<br>
ExternalProject_Add(<br>
ext_seexpr<br>
GIT_REPOSITORY <a href="https://invent.kde.org/lsegovia/SeExpr.git" \
rel="noreferrer" \
target="_blank">https://invent.kde.org/lsegovia/SeExpr.git</a><br>
- GIT_TAG 9c9442c965346325ec7d67c76e139707aa9d3d43<br>
+ GIT_TAG 74737606c01c8a591659c1561b07b695c70f6997<br>
<br>
CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${PREFIX_ext_seexpr} \
-DCMAKE_BUILD_TYPE=${GLOBAL_BUILD_TYPE} -DFLAVOR=${GLOBAL_BUILD_TYPE} \
${GLOBAL_PROFILE} -DBOOST_INCLUDE_DIR=${PREFIX_ext_seexpr}/include \
-DBOOST_ROOT=${PREFIX_ext_seexpr} -DBOOST_LIB_DIR=${PREFIX_ext_seexpr}/lib \
-DENABLE_LLVM_BACKEND=OFF -DENABLE_SSE4=OFF -DBUILD_DOC=OFF -DBUILD_TESTS=OFF \
-DBUILD_UTILS=OFF -DUSE_PYTHON=OFF<br> <br>
</blockquote></div><br clear="all"><br>-- <br><div dir="ltr" \
class="gmail_signature">Dmitry Kazakov</div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic